kylekatarnls/nodejs-php-fallback

View on GitHub

Showing 11 of 54 total issues

The class NodejsPhpFallback has an overall complexity of 79 which is very high. The configured complexity threshold is 50.
Open

class NodejsPhpFallback
{
    protected static $modulePaths = [];
    protected static $maxInstallRetry = 3;
    protected $nodePath;

NodejsPhpFallback has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class NodejsPhpFallback
{
    protected static $modulePaths = [];
    protected static $maxInstallRetry = 3;
    protected $nodePath;
Severity: Minor
Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 3 hrs to fix

    File NodejsPhpFallback.php has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace NodejsPhpFallback;
    
    use Composer\Composer;
    Severity: Minor
    Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 2 hrs to fix

      Function getNpmConfig has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function getNpmConfig(Composer $composer, $key = null)
          {
              $vendorDir = $composer->getConfig()->get('vendor-dir');
      
              $npm = [];
      Severity: Minor
      Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method askForInstall has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function askForInstall(Event $event, $npmConfirm, $npm)
          {
              $io = $event->getIO();
      
              if (!$io->isInteractive()) {
      Severity: Minor
      Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

        Method installPackages has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function installPackages($npm, $onFound = null)
            {
                if (!count($npm)) {
                    return true;
                }
        Severity: Minor
        Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

          Function installPackages has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function installPackages($npm, $onFound = null)
              {
                  if (!count($npm)) {
                      return true;
                  }
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getGlobalInstallChoice has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected static function getGlobalInstallChoice(IOInterface $io, $message)
              {
                  $answer = getenv('NODEJS_PHP_FALLBACK_ANSWER');
          
                  if (is_string($answer) && $answer !== '') {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function askForInstall has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function askForInstall(Event $event, $npmConfirm, $npm)
              {
                  $io = $event->getIO();
          
                  if (!$io->isInteractive()) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method askForInstall() has an NPath complexity of 336. The configured NPath complexity threshold is 200.
          Open

              public static function askForInstall(Event $event, $npmConfirm, $npm)
              {
                  $io = $event->getIO();
          
                  if (!$io->isInteractive()) {

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method askForInstall() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
          Open

              public static function askForInstall(Event $event, $npmConfirm, $npm)
              {
                  $io = $event->getIO();
          
                  if (!$io->isInteractive()) {

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Severity
          Category
          Status
          Source
          Language