Sign upLogin

kylekatarnls/nodejs-php-fallback

View on GitHub
Star
src/NodejsPhpFallback/NodejsPhpFallback.php

Summary

Maintainability
C
1 day
Test Coverage
A
100%

The class NodejsPhpFallback has an overall complexity of 79 which is very high. The configured complexity threshold is 50.
Open

class NodejsPhpFallback
{
    protected static $modulePaths = [];
    protected static $maxInstallRetry = 3;
    protected $nodePath;
Severity: Minor
Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

NodejsPhpFallback has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class NodejsPhpFallback
{
    protected static $modulePaths = [];
    protected static $maxInstallRetry = 3;
    protected $nodePath;
Severity: Minor
Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 3 hrs to fix

    File NodejsPhpFallback.php has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace NodejsPhpFallback;

use Composer\Composer;
    Severity: Minor
    Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 2 hrs to fix

      Function getNpmConfig has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function getNpmConfig(Composer $composer, $key = null)
    {
        $vendorDir = $composer->getConfig()->get('vendor-dir');

        $npm = [];
      Severity: Minor
      Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method askForInstall has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function askForInstall(Event $event, $npmConfirm, $npm)
    {
        $io = $event->getIO();

        if (!$io->isInteractive()) {
      Severity: Minor
      Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

        Method installPackages has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function installPackages($npm, $onFound = null)
    {
        if (!count($npm)) {
            return true;
        }
        Severity: Minor
        Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

          Function installPackages has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function installPackages($npm, $onFound = null)
    {
        if (!count($npm)) {
            return true;
        }
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getGlobalInstallChoice has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected static function getGlobalInstallChoice(IOInterface $io, $message)
    {
        $answer = getenv('NODEJS_PHP_FALLBACK_ANSWER');

        if (is_string($answer) && $answer !== '') {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function askForInstall has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function askForInstall(Event $event, $npmConfirm, $npm)
    {
        $io = $event->getIO();

        if (!$io->isInteractive()) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method askForInstall() has an NPath complexity of 336. The configured NPath complexity threshold is 200.
          Open

              public static function askForInstall(Event $event, $npmConfirm, $npm)
    {
        $io = $event->getIO();

        if (!$io->isInteractive()) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
    function bar() {
        // lots of complicated code
    }
}

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method askForInstall() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
          Open

              public static function askForInstall(Event $event, $npmConfirm, $npm)
    {
        $io = $event->getIO();

        if (!$io->isInteractive()) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Remove error control operator '@' on line 197.
          Open

              protected static function getGlobalInstallChoice(IOInterface $io, $message)
    {
        $answer = getenv('NODEJS_PHP_FALLBACK_ANSWER');

        if (is_string($answer) && $answer !== '') {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          ErrorControlOperator

          Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

          Example

          function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

          Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

          Avoid assigning values to variables in if clauses and the like (line '104', column '70').
          Open

              protected static function getNpmConfig(Composer $composer, $key = null)
    {
        $vendorDir = $composer->getConfig()->get('vendor-dir');

        $npm = [];
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Avoid assigning values to variables in if clauses and the like (line '109', column '76').
          Open

              protected static function getNpmConfig(Composer $composer, $key = null)
    {
        $vendorDir = $composer->getConfig()->get('vendor-dir');

        $npm = [];
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Parameter $event has undeclared type \Composer\EventDispatcher\Event
          Open

              protected static function getPackagesList(Event $event, array $config, array $npm): array
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Parameter $event has undeclared type \Composer\EventDispatcher\Event
          Open

              public static function install(Event $event)
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Call to method getComposer from undeclared class \Composer\EventDispatcher\Event
          Open

                  $composer = $event->getComposer();
          Severity: Critical
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Call to method getIO from undeclared class \Composer\EventDispatcher\Event
          Open

                  $io = $event->getIO();
          Severity: Critical
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Parameter $composer has undeclared type \Composer\Composer
          Open

              protected static function getNpmConfig(Composer $composer, $key = null)
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Call to method getConfig from undeclared class \Composer\Composer
          Open

                  $vendorDir = $composer->getConfig()->get('vendor-dir');
          Severity: Critical
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Call to method getIO from undeclared class \Composer\EventDispatcher\Event
          Open

                  $io = $event->getIO();
          Severity: Critical
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Call to method read from undeclared class \Composer\Json\JsonFile
          Open

                      $dependencyConfig = $json->read();
          Severity: Critical
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Variable $directory is undeclared
          Open

                          if ($dependency === '.' || $dependency === '..' || !is_dir($subDirectory = $directory.DIRECTORY_SEPARATOR.$dependency)) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Argument 1 (haystack) is ?string but \strpos() takes string
          Open

                      if (strpos($result, 'npm ERR!') === false && static::isInstalledPackage($packageNames)) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Parameter $event has undeclared type \Composer\EventDispatcher\Event
          Open

              public static function askForInstall(Event $event, $npmConfirm, $npm)
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Argument 1 (str) is ?string but \substr() takes string
          Open

                  return substr($exec('--version'), 0, 1) === 'v';
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Variable $subDirectory is undeclared
          Open

                          static::appendConfig($npm, $subDirectory, $key);
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Variable $directory is undeclared
          Open

                      foreach (scandir($directory) as $dependency) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Call to method __construct from undeclared class \Composer\Json\JsonFile
          Open

                  $json = new JsonFile($directory.DIRECTORY_SEPARATOR.'composer.json');
          Severity: Critical
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Call to method ask from undeclared class \Composer\IO\IOInterface
          Open

                          $manual = strtolower($io->ask($message));
          Severity: Critical
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Call to method getComposer from undeclared class \Composer\EventDispatcher\Event
          Open

                  $composer = $event->getComposer();
          Severity: Critical
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Parameter $io has undeclared type \Composer\IO\IOInterface
          Open

              protected static function getGlobalInstallChoice(IOInterface $io, $message)
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phan

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

                  $io = $event->getIO();
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

              protected static function getGlobalInstallChoice(IOInterface $io, $message)
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

                  $io = $event->getIO();
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Line exceeds 120 characters; contains 137 characters
          Open

                          if ($dependency === '.' || $dependency === '..' || !is_dir($subDirectory = $directory.DIRECTORY_SEPARATOR.$dependency)) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpcodesniffer

          Line exceeds 120 characters; contains 127 characters
          Open

                      if ($namespace === '.' || $namespace === '..' || !is_dir($directory = $vendorDir.DIRECTORY_SEPARATOR.$namespace)) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpcodesniffer

          There are no issues that match your filters.

          Category
          Status