kylekatarnls/sbp

View on GitHub

Showing 36 of 36 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Sbp\Plugins\Core;

class Methods
Severity: Major
Found in src/Sbp/Plugins/Core/Methods.php and 1 other location - About 1 day to fix
src/Sbp/Plugins/Core/Attributes.php on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 243.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Sbp\Plugins\Core;

class Attributes
Severity: Major
Found in src/Sbp/Plugins/Core/Attributes.php and 1 other location - About 1 day to fix
src/Sbp/Plugins/Core/Methods.php on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 243.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function addBracesOnIndent has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

    public static function addBracesOnIndent($content, $caller)
    {
        $content = explode("\n", $content);
        $curind = array();
        $previousRead = '';
Severity: Minor
Found in src/Sbp/Plugins/Core/Indentation.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Sbp.php has 454 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Sbp;

use Sbp\Plugins\Helpers\FileHelper;
Severity: Minor
Found in src/Sbp/Sbp.php - About 6 hrs to fix

    Function addPlugin has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function addPlugin($plugin, $from = null, $replacement = null)
        {
            static::init();
    
            if (is_null($from)) {
    Severity: Minor
    Found in src/Sbp/Sbp.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Sbp has 34 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Sbp
    {
        const COMMENT = '/* Generated By SBP */';
        const VALIDNAME = '[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*';
        const NUMBER = '(?:0[xbXB])?[0-9]*\.?[0-9]+(?:[eE](?:0[xbXB])?[0-9]*\.?[0-9]+)?';
    Severity: Minor
    Found in src/Sbp/Sbp.php - About 4 hrs to fix

      Method restoreStrings has 92 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function restoreStrings($content, $caller)
          {
              $subst = constant($caller.'::SUBST');
              $value = constant($caller.'::VALUE');
              $number = constant($caller.'::NUMBER');
      Severity: Major
      Found in src/Sbp/Plugins/Core/Compiler.php - About 3 hrs to fix

        Method addBracesOnIndent has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function addBracesOnIndent($content, $caller)
            {
                $content = explode("\n", $content);
                $curind = array();
                $previousRead = '';
        Severity: Major
        Found in src/Sbp/Plugins/Core/Indentation.php - About 2 hrs to fix

          Method quickAccessConstants has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function quickAccessConstants($content, $caller)
              {
                  $validSubst = call_user_func(array($caller, 'getValidStringSurrogates'));
                  $validComments = call_user_func(array($caller, 'getValidComments'));
                  $lastParsedFile = call_user_func(array($caller, 'getLastParsedFile'));
          Severity: Major
          Found in src/Sbp/Plugins/Core/Constants.php - About 2 hrs to fix

            Method getBenchmarkHtml has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected static function getBenchmarkHtml(&$list)
                {
                    $previous = null;
                    $times = array_keys($list);
                    $len = max(0, min(2, max(array_map(function ($key) {
            Severity: Minor
            Found in src/Sbp/Sbp.php - About 1 hr to fix

              Method className has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function className($content, $caller)
                  {
                      return array(
                          '#
                          (
              Severity: Minor
              Found in src/Sbp/Plugins/Core/ClassName.php - About 1 hr to fix

                Method addPlugin has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function addPlugin($plugin, $from = null, $replacement = null)
                    {
                        static::init();
                
                        if (is_null($from)) {
                Severity: Minor
                Found in src/Sbp/Sbp.php - About 1 hr to fix

                  Function register has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function register($prepend = true, $callback = null, $app = null)
                      {
                          if (!static::$registered) {
                              static::$registered = spl_autoload_register(array('\\Sbp\\Laravel\\ClassLoader', 'load'), true, $prepend);
                              if (is_null($app)) {
                  Severity: Minor
                  Found in src/Sbp/Laravel/ClassLoader.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method isBlock has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected static function isBlock(&$line, &$grouped, $iRead, $pattern)
                      {
                          if (substr(rtrim($line), -1) === ';') {
                              return false;
                          }
                  Severity: Minor
                  Found in src/Sbp/Plugins/Core/Indentation.php - About 1 hr to fix

                    Method callOnStringValue has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function callOnStringValue($method, $args)
                        {
                            if (function_exists('preg_'.$method)) {
                                $function = 'preg_'.$method;
                                switch ($method) {
                    Severity: Minor
                    Found in src/Sbp/Handler.php - About 1 hr to fix

                      Method init has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public static function init()
                          {
                              static $coreLoaded = false;
                              if (!$coreLoaded) {
                                  $coreLoaded = true;
                      Severity: Minor
                      Found in src/Sbp/Sbp.php - About 1 hr to fix

                        Function isBlock has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected static function isBlock(&$line, &$grouped, $iRead, $pattern)
                            {
                                if (substr(rtrim($line), -1) === ';') {
                                    return false;
                                }
                        Severity: Minor
                        Found in src/Sbp/Plugins/Core/Indentation.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function restoreStrings has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public static function restoreStrings($content, $caller)
                            {
                                $subst = constant($caller.'::SUBST');
                                $value = constant($caller.'::VALUE');
                                $number = constant($caller.'::NUMBER');
                        Severity: Minor
                        Found in src/Sbp/Plugins/Core/Compiler.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Consider simplifying this complex logical expression.
                        Open

                                        if (($espaces <= $indent || ($indent === -1 && $espaces === 0)) && preg_match('#(?<![a-zA-Z0-9_\x7f-\xff$\(])('.constant($caller.'::ALLOW_EMPTY_BLOCKS').')(?![a-zA-Z0-9_\x7f-\xff])#', $previousRead) && strpos($previousRead, '{') === false) {
                                            $previousRead .= preg_match('`^\s*namespace\s`', $previousRead) || (preg_match('`^\s*([a-zA-Z_]+\s+)*function\s`', $previousRead) && $inInterface !== false) ? ';' : ' {}';
                                        }
                        Severity: Major
                        Found in src/Sbp/Plugins/Core/Indentation.php - About 1 hr to fix

                          Function writeIn has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public static function writeIn($directory = null, $callback = null)
                              {
                                  if (is_null($directory)) {
                                      $directory = static::SAME_DIR;
                                  }
                          Severity: Minor
                          Found in src/Sbp/Sbp.php - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language