lancew/DojoList

View on GitHub

Showing 2,219 of 2,219 total issues

File mapstraction.js has 3944 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
   Copyright (c) 2006-8, Tom Carden, Steve Coast, Mikel Maron, Andrew Turner, Henri Bergius, Rob Moran
   All rights reserved.

   Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
Severity: Major
Found in js/mapstraction.js - About 1 wk to fix

    File prototype-1.6.0.3.js has 3532 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*  Prototype JavaScript framework, version 1.6.0.3
     *  (c) 2005-2008 Sam Stephenson
     *
     *  Prototype is freely distributable under the terms of an MIT-style license.
     *  For details, see the Prototype web site: http://www.prototypejs.org/
    Severity: Major
    Found in js/prototype/prototype-1.6.0.3.js - About 1 wk to fix

      File limonade.php has 1461 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
                                                                        
      // ============================================================================ #
      
      /**
      Severity: Major
      Found in lib/limonade.php - About 3 days to fix

        Function has too many statements (161). Maximum allowed is 30.
        Open

        (function(){
        Severity: Minor
        Found in js/mapstraction.js by eslint

        enforce a maximum number of statements allowed in function blocks (max-statements)

        The max-statements rule allows you to specify the maximum number of statements allowed in a function.

        js function foo() { var bar = 1; // one statement var baz = 2; // two statements var qux = 3; // three statements }

        Rule Details

        This rule enforces a maximum number of statements allowed in function blocks.

        Options

        This rule has a number or object option:

        • "max" (default 10) enforces a maximum number of statements allows in function blocks

        Deprecated: The object property maximum is deprecated; please use the object property max instead.

        This rule has an object option:

        • "ignoreTopLevelFunctions": true ignores top-level functions

        max

        Examples of incorrect code for this rule with the default { "max": 10 } option:

        ```js /eslint max-statements: ["error", 10]/ /eslint-env es6/

        function foo() { var foo1 = 1; var foo2 = 2; var foo3 = 3; var foo4 = 4; var foo5 = 5; var foo6 = 6; var foo7 = 7; var foo8 = 8; var foo9 = 9; var foo10 = 10;

        var foo11 = 11; // Too many. }

        let foo = () => { var foo1 = 1; var foo2 = 2; var foo3 = 3; var foo4 = 4; var foo5 = 5; var foo6 = 6; var foo7 = 7; var foo8 = 8; var foo9 = 9; var foo10 = 10;

        var foo11 = 11; // Too many. }; ```

        Examples of correct code for this rule with the default { "max": 10 } option:

        ```js /eslint max-statements: ["error", 10]/ /eslint-env es6/

        function foo() { var foo1 = 1; var foo2 = 2; var foo3 = 3; var foo4 = 4; var foo5 = 5; var foo6 = 6; var foo7 = 7; var foo8 = 8; var foo9 = 9; var foo10 = 10; return function () {

        // The number of statements in the inner function does not count toward the
        // statement maximum.
        
        return 42;
        

        }; }

        let foo = () => { var foo1 = 1; var foo2 = 2; var foo3 = 3; var foo4 = 4; var foo5 = 5; var foo6 = 6; var foo7 = 7; var foo8 = 8; var foo9 = 9; var foo10 = 10; return function () {

        // The number of statements in the inner function does not count toward the
        // statement maximum.
        
        return 42;
        

        }; } ```

        ignoreTopLevelFunctions

        Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

        ```js /eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]/

        function foo() { var foo1 = 1; var foo2 = 2; var foo3 = 3; var foo4 = 4; var foo5 = 5; var foo6 = 6; var foo7 = 7; var foo8 = 8; var foo9 = 9; var foo10 = 10; var foo11 = 11; } ```

        Related Rules

        • [complexity](complexity.md)
        • [max-depth](max-depth.md)
        • [max-len](max-len.md)
        • [max-nested-callbacks](max-nested-callbacks.md)
        • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    this.layers['osm'] = new OpenLayers.Layer.TMS(
                        'OSM',
                        [
                        "http://a.tah.openstreetmap.org/Tiles/tile.php/",
                        "http://b.tah.openstreetmap.org/Tiles/tile.php/",
        Severity: Major
        Found in js/mapstraction.js and 1 other location - About 1 day to fix
        js/mapstraction.js on lines 387..416

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 326.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    this.layers['osmmapnik'] = new OpenLayers.Layer.TMS(
                        'OSM Mapnik',
                        [
                        "http://a.tile.openstreetmap.org/",
                        "http://b.tile.openstreetmap.org/",
        Severity: Major
        Found in js/mapstraction.js and 1 other location - About 1 day to fix
        js/mapstraction.js on lines 418..447

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 326.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function addAPI has 332 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Mapstraction.prototype.addAPI = function(element,api) {
            this.loaded[api] = false;
            this.onload[api] = [];
            var me = this;
        
        Severity: Major
        Found in js/mapstraction.js - About 1 day to fix

          Function Autocompleter has 273 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          $.Autocompleter = function(input, options) {
          
              var KEY = {
                  UP: 38,
                  DOWN: 40,
          Severity: Major
          Found in bugs/static/prophet/jquery/js/jquery-autocomplete.js - About 1 day to fix

            File jquery-autocomplete.js has 618 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /*
             * Autocomplete - jQuery plugin 1.0.2
             *
             * Copyright (c) 2007 Dylan Verheul, Dan G. Switzer, Anjesh Tuladhar, Jörn Zaefferer
             *
            Severity: Major
            Found in bugs/static/prophet/jquery/js/jquery-autocomplete.js - About 1 day to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              Marker.prototype.hide = function() {
                  if (this.api) {
                      switch (this.api) {
                          case 'google':
                          case 'openstreetmap':
              Severity: Major
              Found in js/mapstraction.js and 1 other location - About 1 day to fix
              js/mapstraction.js on lines 4634..4664

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 204.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              Marker.prototype.show = function() {
                  if (this.api) {
                      switch (this.api) {
                          case 'google':
                          case 'openstreetmap':
              Severity: Major
              Found in js/mapstraction.js and 1 other location - About 1 day to fix
              js/mapstraction.js on lines 4599..4629

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 204.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if ($file["CoachPhoto"]["name"]) {
                      if ((($file["CoachPhoto"]["type"] == "image/gif")
                          || ($file["CoachPhoto"]["type"] == "image/jpeg")
                          || ($file["CoachPhoto"]["type"] == "image/pjpeg")
                          || ($file["CoachPhoto"]["type"] == "image/png"))
              Severity: Major
              Found in lib/dojo.model.php and 1 other location - About 1 day to fix
              lib/dojo.model.php on lines 78..96

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 207.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if ($file["DojoLogo"]["name"]) {
                      if ((($file["DojoLogo"]["type"] == "image/gif")
                          || ($file["DojoLogo"]["type"] == "image/jpeg")
                          || ($file["DojoLogo"]["type"] == "image/pjpeg")
                          || ($file["DojoLogo"]["type"] == "image/png"))
              Severity: Major
              Found in lib/dojo.model.php and 1 other location - About 1 day to fix
              lib/dojo.model.php on lines 103..121

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 207.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Methods has 56 functions (exceeds 20 allowed). Consider refactoring.
              Open

              Element.Methods = {
                visible: function(element) {
                  return $(element).style.display != 'none';
                },
              
              
              Severity: Major
              Found in js/prototype/prototype-1.6.0.3.js - About 1 day to fix

                Function has too many statements (78). Maximum allowed is 30.
                Open

                Mapstraction.prototype.addAPI = function(element,api) {
                Severity: Minor
                Found in js/mapstraction.js by eslint

                enforce a maximum number of statements allowed in function blocks (max-statements)

                The max-statements rule allows you to specify the maximum number of statements allowed in a function.

                js function foo() { var bar = 1; // one statement var baz = 2; // two statements var qux = 3; // three statements }

                Rule Details

                This rule enforces a maximum number of statements allowed in function blocks.

                Options

                This rule has a number or object option:

                • "max" (default 10) enforces a maximum number of statements allows in function blocks

                Deprecated: The object property maximum is deprecated; please use the object property max instead.

                This rule has an object option:

                • "ignoreTopLevelFunctions": true ignores top-level functions

                max

                Examples of incorrect code for this rule with the default { "max": 10 } option:

                ```js /eslint max-statements: ["error", 10]/ /eslint-env es6/

                function foo() { var foo1 = 1; var foo2 = 2; var foo3 = 3; var foo4 = 4; var foo5 = 5; var foo6 = 6; var foo7 = 7; var foo8 = 8; var foo9 = 9; var foo10 = 10;

                var foo11 = 11; // Too many. }

                let foo = () => { var foo1 = 1; var foo2 = 2; var foo3 = 3; var foo4 = 4; var foo5 = 5; var foo6 = 6; var foo7 = 7; var foo8 = 8; var foo9 = 9; var foo10 = 10;

                var foo11 = 11; // Too many. }; ```

                Examples of correct code for this rule with the default { "max": 10 } option:

                ```js /eslint max-statements: ["error", 10]/ /eslint-env es6/

                function foo() { var foo1 = 1; var foo2 = 2; var foo3 = 3; var foo4 = 4; var foo5 = 5; var foo6 = 6; var foo7 = 7; var foo8 = 8; var foo9 = 9; var foo10 = 10; return function () {

                // The number of statements in the inner function does not count toward the
                // statement maximum.
                
                return 42;
                

                }; }

                let foo = () => { var foo1 = 1; var foo2 = 2; var foo3 = 3; var foo4 = 4; var foo5 = 5; var foo6 = 6; var foo7 = 7; var foo8 = 8; var foo9 = 9; var foo10 = 10; return function () {

                // The number of statements in the inner function does not count toward the
                // statement maximum.
                
                return 42;
                

                }; } ```

                ignoreTopLevelFunctions

                Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

                ```js /eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]/

                function foo() { var foo1 = 1; var foo2 = 2; var foo3 = 3; var foo4 = 4; var foo5 = 5; var foo6 = 6; var foo7 = 7; var foo8 = 8; var foo9 = 9; var foo10 = 10; var foo11 = 11; } ```

                Related Rules

                • [complexity](complexity.md)
                • [max-depth](max-depth.md)
                • [max-len](max-len.md)
                • [max-nested-callbacks](max-nested-callbacks.md)
                • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

                Function request_uri has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
                Open

                function request_uri($env = null)
                {
                    static $uri = null;
                    if(is_null($env)) {
                        if(!is_null($uri)) { return $uri;
                Severity: Minor
                Found in lib/limonade.php - About 7 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function route_build has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
                Open

                function route_build($method, $path_or_array, $callback, $options = array())
                {
                    $method = strtoupper($method);
                    if(!in_array($method, request_methods())) { 
                        trigger_error("'$method' request method is unkown or unavailable.", E_USER_WARNING);
                Severity: Minor
                Found in lib/limonade.php - About 7 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function Select has 169 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                $.Autocompleter.Select = function (options, input, select, config) {
                    var CLASSES = {
                        ACTIVE: "ac_over"
                    };
                    
                Severity: Major
                Found in bugs/static/prophet/jquery/js/jquery-autocomplete.js - About 6 hrs to fix

                  Function addControls has 167 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  Mapstraction.prototype.addControls = function( args ) {
                      if(this.loaded[this.api] === false) {
                          var me = this;
                          this.onload[this.api].push( function() {
                              me.addControls(args);
                  Severity: Major
                  Found in js/mapstraction.js - About 6 hrs to fix

                    Function id has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
                    Open

                        id: function(nodes, root, id, combinator) {
                          var targetNode = $(id), h = Selector.handlers;
                          if (!targetNode) return [];
                          if (!nodes && root == document) return [targetNode];
                          if (nodes) {
                    Severity: Minor
                    Found in js/prototype/prototype-1.6.0.3.js - About 6 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language