larsvanbraam/transition-controller

View on GitHub

Showing 13 of 32 total issues

File AbstractTransitionController.ts has 360 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { TimelineMax, Animation } from 'gsap';
import EventDispatcher from 'seng-event';
import TransitionEvent from './event/TransitionEvent';
import { IAbstractTransitionControllerOptions } from './interface/IAbstractTranstitionControllerOptions';
import { clearTimeline, cloneTimeline, createTimeline } from './util/TimelineUtils';
Severity: Minor
Found in src/lib/AbstractTransitionController.ts - About 4 hrs to fix

    Function transitionIn has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public transitionIn(forceTransition: boolean = false): Promise<void> {
        let oldTransitionPromise = Promise.resolve();
    
        /**
         * Check if we already have a transition out going on, if so we finish it right away! and trigger a
    Severity: Major
    Found in src/lib/AbstractTransitionController.ts - About 2 hrs to fix

      Function transitionOut has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public transitionOut(
          forceTransition: boolean = false,
          id: string = this.options.transitionOutId,
          reset: boolean = false,
        ): Promise<void> {
      Severity: Major
      Found in src/lib/AbstractTransitionController.ts - About 2 hrs to fix

        Function cloneTimeline has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

        export function cloneTimeline(source: TimelineMax, direction: TransitionDirection): TimelineMax {
          const children = source.getChildren(false);
          const timeline = new TimelineMax(source.vars);
        
          const parseChild = (child, timeline) => {
        Severity: Minor
        Found in src/lib/util/TimelineUtils.ts - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createTimeline has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        export function createTimeline(options: ICreateTimelineOptions): TimelineMax {
          let forward = true;
          let lastTime = 0;
        
          const timeline = new TimelineMax({
        Severity: Minor
        Found in src/lib/util/TimelineUtils.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setupTransitionInTimeline has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public setupTransitionInTimeline(timeline: TimelineMax, parent: Vue, id: string ): void {
            switch (id) {
              case TransitionId[TransitionDirection.IN].RIGHT_TO_LEFT:
                timeline.fromTo(
                  parent.$el,

          Function setupTimeline has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            public setupTimeline(type: TimelineType, reset: boolean = true, id?: string) {
              let timeline;
              let transitionId;
              let setupMethod;
          
          
          Severity: Minor
          Found in src/lib/AbstractTransitionController.ts - About 1 hr to fix

            Function transitionIn has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              public transitionIn(forceTransition: boolean = false): Promise<void> {
                let oldTransitionPromise = Promise.resolve();
            
                /**
                 * Check if we already have a transition out going on, if so we finish it right away! and trigger a
            Severity: Minor
            Found in src/lib/AbstractTransitionController.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function setupTimeline has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              public setupTimeline(type: TimelineType, reset: boolean = true, id?: string) {
                let timeline;
                let transitionId;
                let setupMethod;
            
            
            Severity: Minor
            Found in src/lib/AbstractTransitionController.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function cloneTimeline has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function cloneTimeline(source: TimelineMax, direction: TransitionDirection): TimelineMax {
              const children = source.getChildren(false);
              const timeline = new TimelineMax(source.vars);
            
              const parseChild = (child, timeline) => {
            Severity: Minor
            Found in src/lib/util/TimelineUtils.ts - About 1 hr to fix

              Function handleStartClick has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  handleStartClick(type, component) {
                    this.started = true;
                    // Clear the events
                    this.events = [];
                    // Get the transition controller
              Severity: Minor
              Found in example/src/index.js - About 1 hr to fix

                Function handleTransitionComplete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                  private handleTransitionComplete(direction: TransitionDirection): void {
                    switch (direction) {
                      case TransitionDirection.IN:
                        this.transitionInPromise = null;
                        if (this.transitionInResolveMethod !== null) {
                Severity: Minor
                Found in src/lib/AbstractTransitionController.ts - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function transitionOut has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  public transitionOut(
                    forceTransition: boolean = false,
                    id: string = this.options.transitionOutId,
                    reset: boolean = false,
                  ): Promise<void> {
                Severity: Minor
                Found in src/lib/AbstractTransitionController.ts - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language