Sign upLogin

lbryio/chainquery

View on GitHub
Star
daemon/jobs/chainvalidation.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function ValidateChainRange has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
Open

func ValidateChainRange(from, to *uint64) ([]BlockData, error) {

    if from == nil {
        start := uint64(0)
        from = &start
Severity: Minor
Found in daemon/jobs/chainvalidation.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ValidateChainRange has 8 return statements (exceeds 4 allowed).
Open

func ValidateChainRange(from, to *uint64) ([]BlockData, error) {

    if from == nil {
        start := uint64(0)
        from = &start
Severity: Major
Found in daemon/jobs/chainvalidation.go - About 50 mins to fix

Function checkTxs has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
Open

func checkTxs(missingData []BlockData, lbryBlock *lbrycrd.GetBlockResponse, transactions model.TransactionSlice) ([]BlockData, error) {
    for _, lbryTxHash := range lbryBlock.Tx {
        var tx *model.Transaction
        for _, transaction := range transactions {
            if transaction.Hash == lbryTxHash {
Severity: Minor
Found in daemon/jobs/chainvalidation.go - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ValidateChain has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Wontfix

func ValidateChain() {
    if !validatingChain {
        go func() {
            metrics.JobLoad.WithLabelValues("validate_chain").Inc()
            defer metrics.JobLoad.WithLabelValues("validate_chain").Dec()
Severity: Minor
Found in daemon/jobs/chainvalidation.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status