Sign upLogin

lbryio/chainquery

View on GitHub
Star
lbrycrd/script.go

Summary

Maintainability
C
1 day
Test Coverage

Function readCompactSize has 8 return statements (exceeds 4 allowed).
Open

func readCompactSize(bs *bytes.Buffer) (uint64, []byte, error) {
    var readBuf []byte
    bSize := make([]byte, 1)
    _, err := bs.Read(bSize)
    if err != nil {
Severity: Major
Found in lbrycrd/script.go - About 50 mins to fix

Avoid deeply nested control flow statements.
Open

            if err != nil {
                return
            }
Severity: Major
Found in lbrycrd/script.go - About 45 mins to fix

Function GetPubKeyScriptFromClaimPKS has 7 return statements (exceeds 4 allowed).
Open

func GetPubKeyScriptFromClaimPKS(script []byte) (pubkeyscript []byte, err error) {
    if IsClaimScript(script) {
        if IsClaimNameScript(script) {
            _, _, pubkeyscript, err = ParseClaimNameScript(script)
            if err != nil {
Severity: Major
Found in lbrycrd/script.go - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

    } else if txscript.IsPayToWitnessScriptHash(script) {
        return p2WSH
    }
Severity: Major
Found in lbrycrd/script.go - About 45 mins to fix

Function getPublicKeyScriptType has 6 return statements (exceeds 4 allowed).
Open

func getPublicKeyScriptType(script []byte) string {
    if isPayToPublicKey(script) {
        return p2PK
    } else if isPayToPublicKeyHashScript(script) {
        return p2PKH
Severity: Major
Found in lbrycrd/script.go - About 40 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if dataPushType == opPushdata1 {
        valueBytesToRead = int(script[claimidEnd+1])
        valueStart = claimidEnd + 2
    } else if dataPushType == opPushdata2 {
        valueStart = claimidEnd + 3
Severity: Major
Found in lbrycrd/script.go and 1 other location - About 1 hr to fix
lbrycrd/script.go on lines 154..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 138.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if dataPushType == opPushdata1 {
        valueBytesToRead = int(script[nameEnd+1])
        valueStart = nameEnd + 2
    } else if dataPushType == opPushdata2 {
        valueStart = nameEnd + 3
Severity: Major
Found in lbrycrd/script.go and 1 other location - About 1 hr to fix
lbrycrd/script.go on lines 247..256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 138.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func getAddressFromP2WPKH(hexstring string) (string, error) {
    witnessProgram, err := hex.DecodeString(hexstring)
    if err != nil {
        return "", err
    }
Severity: Major
Found in lbrycrd/script.go and 4 other locations - About 55 mins to fix
lbrycrd/script.go on lines 349..365
lbrycrd/script.go on lines 367..383
lbrycrd/script.go on lines 385..401
lbrycrd/script.go on lines 421..437

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func getAddressFromP2WSH(hexstring string) (string, error) {
    witnessProgram, err := hex.DecodeString(hexstring)
    if err != nil {
        return "", err
    }
Severity: Major
Found in lbrycrd/script.go and 4 other locations - About 55 mins to fix
lbrycrd/script.go on lines 349..365
lbrycrd/script.go on lines 367..383
lbrycrd/script.go on lines 385..401
lbrycrd/script.go on lines 403..419

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func getAddressFromP2PKH(hexstring string) (string, error) {
    hexstringBytes, err := hex.DecodeString(hexstring)
    if err != nil {
        return "", err
    }
Severity: Major
Found in lbrycrd/script.go and 4 other locations - About 55 mins to fix
lbrycrd/script.go on lines 349..365
lbrycrd/script.go on lines 385..401
lbrycrd/script.go on lines 403..419
lbrycrd/script.go on lines 421..437

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func getAddressFromP2SH(hexstring string) (string, error) {
    hexstringBytes, err := hex.DecodeString(hexstring)
    if err != nil {
        return "", err
    }
Severity: Major
Found in lbrycrd/script.go and 4 other locations - About 55 mins to fix
lbrycrd/script.go on lines 349..365
lbrycrd/script.go on lines 367..383
lbrycrd/script.go on lines 403..419
lbrycrd/script.go on lines 421..437

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func getAddressFromP2PK(hexstring string) (string, error) {
    hexstringBytes, err := hex.DecodeString(hexstring)
    if err != nil {
        return "", err
    }
Severity: Major
Found in lbrycrd/script.go and 4 other locations - About 55 mins to fix
lbrycrd/script.go on lines 367..383
lbrycrd/script.go on lines 385..401
lbrycrd/script.go on lines 403..419
lbrycrd/script.go on lines 421..437

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Your code does not pass gofmt in 2 places. Go fmt your code!
Open

package lbrycrd
Severity: Minor
Found in lbrycrd/script.go by gofmt

There are no issues that match your filters.

Category
Status