Sign upLogin

learningworks/moodle-block_lw_courses

View on GitHub
Star
block_lw_courses.php

Summary

Maintainability
A
1 hr
Test Coverage

Method get_content has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_content() {
        global $USER, $CFG;
        require_once($CFG->dirroot.'/user/profile/lib.php');

        if ($this->content !== null) {
Severity: Minor
Found in block_lw_courses.php - About 1 hr to fix

    Function get_content has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get_content() {
        global $USER, $CFG;
        require_once($CFG->dirroot.'/user/profile/lib.php');

        if ($this->content !== null) {
    Severity: Minor
    Found in block_lw_courses.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '61', column '30').
    Open

            $this->content = new stdClass();
    Severity: Minor
    Found in block_lw_courses.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    There are no issues that match your filters.

    Category
    Status