Sign upLogin

ledbettj/systemd-journal

View on GitHub
Star

Showing 4 of 4 total issues

Class Journal has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Journal
    include Enumerable
    include Systemd::Journal::Writable
    include Systemd::Journal::Navigable
    include Systemd::Journal::Filterable
Severity: Minor
Found in lib/systemd/journal.rb - About 2 hrs to fix

    Method wait has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def wait(timeout_usec = -1, opts = {})
        if opts[:select] && !IS_JRUBY
          wait_select(timeout_usec)
        else
          rc = Native.sd_journal_wait(@ptr, timeout_usec)
    Severity: Minor
    Found in lib/systemd/journal/waitable.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_options! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate_options!(opts)
      exclusive = [:path, :files, :container, :file]
      given = (opts.keys & exclusive)

      raise ArgumentError, "conflicting options: #{given}" if given.length > 1
    Severity: Minor
    Found in lib/systemd/journal.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method catalog has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def catalog(opts = {})
      return nil unless catalog?

      opts[:replace] = true unless opts.key?(:replace)
    Severity: Minor
    Found in lib/systemd/journal_entry.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language