Showing 222 of 257 total issues

Avoid too many return statements within this function.
Open

                return 'CASiteMinder'
Severity: Major
Found in src/pyff/samlmd.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return 'PySAML'
    Severity: Major
    Found in src/pyff/samlmd.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return 'SURFConext'
      Severity: Major
      Found in src/pyff/samlmd.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return 'other'
        Severity: Major
        Found in src/pyff/samlmd.py - About 30 mins to fix

          Function entity_attribute_dict has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def entity_attribute_dict(entity):
              d = {}
          
              def _u(an, values):
                  d[an] = values
          Severity: Minor
          Found in src/pyff/samlmd.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _entities has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def _entities(self):
                  lst = set()
                  for ref_data in self.parts.values():
                      for ref in ref_data['items']:
                          e = self.objects.get(ref, None)
          Severity: Minor
          Found in src/pyff/store.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function sort_entities has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def sort_entities(t, sxp=None):
              """
              Sorts the working entities 't' by the value returned by the xpath 'sxp'
              By default, entities are sorted by 'entityID' when this method is called without 'sxp', and otherwise as
              second criteria.
          Severity: Minor
          Found in src/pyff/samlmd.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function set_nodecountry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def set_nodecountry(e, country_code):
              """Set eidas:NodeCountry on an EntityDescriptor
          
              :param e: The EntityDescriptor element
              :param country_code: An ISO country code
          Severity: Minor
          Found in src/pyff/samlmd.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _modify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def _modify(self, entity, modifier):
                  def _m(idx, vv):
                      getattr(idx.setdefault(vv, EntitySet()), modifier)(entity)
          
                  for hn in DINDEX:
          Severity: Minor
          Found in src/pyff/store.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function filter_invalids_from_document has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def filter_invalids_from_document(t: ElementTree, base_url, validation_errors) -> ElementTree:
              xsd = schema()
              for e in iter_entities(t):
                  if not xsd.validate(e):
                      error = xml_error(xsd.error_log, m=base_url)
          Severity: Minor
          Found in src/pyff/samlmd.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function sub_domains has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def sub_domains(e):
              lst = []
              domains = entity_domains(e)
              for d in domains:
                  for sub in subdomains(d):
          Severity: Minor
          Found in src/pyff/samlmd.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function xslt_transform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def xslt_transform(t, stylesheet, params=None):
              if not params:
                  params = dict()
          
              if not hasattr(thread_data, 'xslt'):
          Severity: Minor
          Found in src/pyff/utils.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function load_requirements has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def load_requirements(path: PurePath) -> List[str]:
              """ Load dependencies from a requirements.txt style file, ignoring comments etc. """
              res = []
              with open(path) as fd:
                  for line in fd.readlines():
          Severity: Minor
          Found in setup.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function b2u has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def b2u(data: Union[str, bytes, Tuple, List, Set]) -> Union[str, bytes, Tuple, List, Set]:
              if is_text(data):
                  return data
              elif isinstance(data, six.binary_type):
                  return data.decode("utf-8")
          Severity: Minor
          Found in src/pyff/utils.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function json_serializer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def json_serializer(o):
              if isinstance(o, datetime):
                  return o.__str__()
              if isinstance(o, CaseInsensitiveDict):
                  return dict(o.items())
          Severity: Minor
          Found in src/pyff/utils.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function main has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def main():
              """
              The (new) main entrypoint for the pyffd command.
              """
              args = parse_options("pyffd", __doc__)
          Severity: Minor
          Found in src/pyff/mdq.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _nodecountry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def _nodecountry(req: Plumbing.Request, *opts):
              """
              Sets eidas:NodeCountry
          
              :param req: The request
          Severity: Minor
          Found in src/pyff/builtins.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function help has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def help(prg):
                  hlp = "Usage: {} [options+] <pipeline file (yaml)>\n\n"
                  for s in config.settings():
                      if prg in s.cmdline and not s.deprecated and not s.hidden:
                          h = " --{}".format(s.long_name)
          Severity: Minor
          Found in src/pyff/constants.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def parse(self, resource: Resource, content: str) -> ParserInfo:
                  info = ParserInfo(description='XRD links', expiration_time='never expires')
                  t = parse_xml(unicode_stream(content))
          
                  relt = root(t)
          Severity: Minor
          Found in src/pyff/parse.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function valid_until_ts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def valid_until_ts(elt, default_ts: int) -> int:
              ts = default_ts
              valid_until = elt.get("validUntil", None)
              if valid_until is not None:
                  try:
          Severity: Minor
          Found in src/pyff/utils.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language