Showing 392 of 392 total issues

Cyclomatic complexity is too high in method release. (6)
Open

    def release(self):
        """Release the currently held lock.

    * In case the current thread holds no lock, a ValueError is thrown."""

Severity: Minor
Found in src/pyff/locks.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

| Construct | Effect on CC | Reasoning | | --------- | ------------ | --------- | | if | +1 | An if statement is a single decision. | | elif| +1| The elif statement adds another decision. | | else| +0| The else statement does not cause a new decision. The decision is at the if. | | for| +1| There is a decision at the start of the loop. | | while| +1| There is a decision at the while statement. | | except| +1| Each except branch adds a new conditional path of execution. | | finally| +0| The finally block is unconditionally executed. | | with| +1| The with statement roughly corresponds to a try/except block (see PEP 343 for details). | | assert| +1| The assert statement internally roughly equals a conditional statement. | | Comprehension| +1| A list/set/dict comprehension of generator expression is equivalent to a for loop. | | Boolean Operator| +1| Every boolean operator (and, or) adds a decision point. |

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method __init__. (6)
Open

    def __init__(self, pipes=None, observers=None):

        if not observers:
            observers = []
        if not pipes:
Severity: Minor
Found in src/pyff/mdx.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

| Construct | Effect on CC | Reasoning | | --------- | ------------ | --------- | | if | +1 | An if statement is a single decision. | | elif| +1| The elif statement adds another decision. | | else| +0| The else statement does not cause a new decision. The decision is at the if. | | for| +1| There is a decision at the start of the loop. | | while| +1| There is a decision at the while statement. | | except| +1| Each except branch adds a new conditional path of execution. | | finally| +0| The finally block is unconditionally executed. | | with| +1| The with statement roughly corresponds to a try/except block (see PEP 343 for details). | | assert| +1| The assert statement internally roughly equals a conditional statement. | | Comprehension| +1| A list/set/dict comprehension of generator expression is equivalent to a for loop. | | Boolean Operator| +1| Every boolean operator (and, or) adds a decision point. |

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function set_reginfo. (6)
Open

def set_reginfo(e, policy=None, authority=None):
    if e.tag != "{%s}EntityDescriptor" % NS['md']:
        raise MetadataException("I can only set RegistrationAuthority to EntityDescriptor elements")
    if authority is None:
        raise MetadataException("At least authority must be provided")
Severity: Minor
Found in src/pyff/samlmd.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

| Construct | Effect on CC | Reasoning | | --------- | ------------ | --------- | | if | +1 | An if statement is a single decision. | | elif| +1| The elif statement adds another decision. | | else| +0| The else statement does not cause a new decision. The decision is at the if. | | for| +1| There is a decision at the start of the loop. | | while| +1| There is a decision at the while statement. | | except| +1| Each except branch adds a new conditional path of execution. | | finally| +0| The finally block is unconditionally executed. | | with| +1| The with statement roughly corresponds to a try/except block (see PEP 343 for details). | | assert| +1| The assert statement internally roughly equals a conditional statement. | | Comprehension| +1| A list/set/dict comprehension of generator expression is equivalent to a for loop. | | Boolean Operator| +1| Every boolean operator (and, or) adds a decision point. |

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function entity_attribute_dict. (6)
Open

def entity_attribute_dict(entity):
    d = {}

    def _u(an, values):
        d[an] = values
Severity: Minor
Found in src/pyff/samlmd.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

| Construct | Effect on CC | Reasoning | | --------- | ------------ | --------- | | if | +1 | An if statement is a single decision. | | elif| +1| The elif statement adds another decision. | | else| +0| The else statement does not cause a new decision. The decision is at the if. | | for| +1| There is a decision at the start of the loop. | | while| +1| There is a decision at the while statement. | | except| +1| Each except branch adds a new conditional path of execution. | | finally| +0| The finally block is unconditionally executed. | | with| +1| The with statement roughly corresponds to a try/except block (see PEP 343 for details). | | assert| +1| The assert statement internally roughly equals a conditional statement. | | Comprehension| +1| A list/set/dict comprehension of generator expression is equivalent to a for loop. | | Boolean Operator| +1| Every boolean operator (and, or) adds a decision point. |

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method _find_matching_files. (6)
Open

    def _find_matching_files(self, d):
        log.debug("find files in {}".format(repr(d)))
        for top, dirs, files in os.walk(d):
            for dn in dirs:
                if dn.startswith("."):
Severity: Minor
Found in src/pyff/parse.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

| Construct | Effect on CC | Reasoning | | --------- | ------------ | --------- | | if | +1 | An if statement is a single decision. | | elif| +1| The elif statement adds another decision. | | else| +0| The else statement does not cause a new decision. The decision is at the if. | | for| +1| There is a decision at the start of the loop. | | while| +1| There is a decision at the while statement. | | except| +1| Each except branch adds a new conditional path of execution. | | finally| +0| The finally block is unconditionally executed. | | with| +1| The with statement roughly corresponds to a try/except block (see PEP 343 for details). | | assert| +1| The assert statement internally roughly equals a conditional statement. | | Comprehension| +1| A list/set/dict comprehension of generator expression is equivalent to a for loop. | | Boolean Operator| +1| Every boolean operator (and, or) adds a decision point. |

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function xslt_transform. (6)
Open

def xslt_transform(t, stylesheet, params=None):
    if not params:
        params = dict()

    if not hasattr(thread_data, 'xslt'):
Severity: Minor
Found in src/pyff/utils.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

| Construct | Effect on CC | Reasoning | | --------- | ------------ | --------- | | if | +1 | An if statement is a single decision. | | elif| +1| The elif statement adds another decision. | | else| +0| The else statement does not cause a new decision. The decision is at the if. | | for| +1| There is a decision at the start of the loop. | | while| +1| There is a decision at the while statement. | | except| +1| Each except branch adds a new conditional path of execution. | | finally| +0| The finally block is unconditionally executed. | | with| +1| The with statement roughly corresponds to a try/except block (see PEP 343 for details). | | assert| +1| The assert statement internally roughly equals a conditional statement. | | Comprehension| +1| A list/set/dict comprehension of generator expression is equivalent to a for loop. | | Boolean Operator| +1| Every boolean operator (and, or) adds a decision point. |

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method lookup. (6)
Open

    def lookup(self, member, xp=None, store=None):
        """
Lookup elements in the working metadata repository

:param member: A selector (cf below)
Severity: Minor
Found in src/pyff/mdrepo.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

| Construct | Effect on CC | Reasoning | | --------- | ------------ | --------- | | if | +1 | An if statement is a single decision. | | elif| +1| The elif statement adds another decision. | | else| +0| The else statement does not cause a new decision. The decision is at the if. | | for| +1| There is a decision at the start of the loop. | | while| +1| There is a decision at the while statement. | | except| +1| Each except branch adds a new conditional path of execution. | | finally| +0| The finally block is unconditionally executed. | | with| +1| The with statement roughly corresponds to a try/except block (see PEP 343 for details). | | assert| +1| The assert statement internally roughly equals a conditional statement. | | Comprehension| +1| A list/set/dict comprehension of generator expression is equivalent to a for loop. | | Boolean Operator| +1| Every boolean operator (and, or) adds a decision point. |

Source: http://radon.readthedocs.org/en/latest/intro.html

Function main has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def main():
    """
    The main entrypoint for the pyFF cmdline tool.
    """

Severity: Minor
Found in src/pyff/md.py - About 1 hr to fix

    Function load has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    @pipe
    def load(req, *opts):
        """
    General-purpose resource fetcher.
    
    
    Severity: Minor
    Found in src/pyff/builtins.py - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  lst.sort(function (a, b) { // decending order - most commonly used stuff on top
                      if (a.use_count < b.use_count) {
                          return 1;
                      }
                      if (a.use_count > b.use_count) {
      Severity: Major
      Found in src/pyff/site/static/js/ds-client.js and 1 other location - About 1 hr to fix
      src/pyff/site/static/js/ds-client.js on lines 66..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  lst.sort(function (a, b) { // decending order - most commonly used stuff on top
                      if (a.use_count < b.use_count) {
                          return 1;
                      }
                      if (a.use_count > b.use_count) {
      Severity: Major
      Found in src/pyff/site/static/js/ds-client.js and 1 other location - About 1 hr to fix
      src/pyff/site/static/js/ds-client.js on lines 102..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      def entity_service_description(entity, langs=None):
          for serviceName in filter_lang(entity.iter("{%s}ServiceDescription" % NS['md']), langs=langs):
              return serviceName.text
      Severity: Major
      Found in src/pyff/samlmd.py and 1 other location - About 1 hr to fix
      src/pyff/samlmd.py on lines 614..616

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      def entity_service_name(entity, langs=None):
          for serviceName in filter_lang(entity.iter("{%s}ServiceName" % NS['md']), langs=langs):
              return serviceName.text
      Severity: Major
      Found in src/pyff/samlmd.py and 1 other location - About 1 hr to fix
      src/pyff/samlmd.py on lines 619..621

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Error: invalid syntax (<unknown>, line 28)</unknown>
      Open

      print etree.tostring(xrds, pretty_print=True)
      Severity: Minor
      Found in scripts/csv2xrd.py by radon

      We encountered an error attempting to analyze this line.

      Error: invalid syntax (<unknown>, line 7)</unknown>
      Open

          print yaml.safe_load(fd)
      Severity: Minor
      Found in scripts/yamltest.py by radon

      We encountered an error attempting to analyze this line.

      Function update has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def update(self, t, tid=None, ts=None, merge_strategy=None):  # TODO: merge ?
              log.debug("redis store update: %s: %s" % (t, tid))
              relt = root(t)
              ne = 0
              if ts is None:
      Severity: Minor
      Found in src/pyff/store.py - About 1 hr to fix

        Function entitiesdescriptor has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        def entitiesdescriptor(entities,
                               name,
                               lookup_fn=None,
                               cache_duration=None,
                               valid_until=None,
        Severity: Minor
        Found in src/pyff/samlmd.py - About 1 hr to fix

          Function discojson has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          def discojson(e, langs=None):
              if e is None:
                  return dict()
          
              title, descr = entity_extended_display(e)
          Severity: Minor
          Found in src/pyff/samlmd.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function retry has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          def retry(ex, tries=4, delay=3, backoff=2, logger=log):
              """Retry calling the decorated function using exponential backoff based on
          
              * http://www.saltycrane.com/blog/2009/11/trying-out-retry-decorator-python/
              * http://wiki.python.org/moin/PythonDecoratorLibrary#Retry
          Severity: Minor
          Found in src/pyff/decorators.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function iprocess has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              def iprocess(self, req):
                  """The inner request pipeline processor.
          
                  :param req: The request to run through the pipeline
                  """
          Severity: Minor
          Found in src/pyff/pipes.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language