librariesio/libraries.io

View on GitHub
app/controllers/application_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Class ApplicationController has 34 methods (exceeds 20 allowed). Consider refactoring.
Open

class ApplicationController < ActionController::Base
  include Rails::Pagination
  # Prevent CSRF attacks by raising an exception.
  # For APIs, you may want to use :null_session instead.
  protect_from_forgery with: :exception
Severity: Minor
Found in app/controllers/application_controller.rb - About 4 hrs to fix

    Method find_version has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

      def find_version
        @version_count = @project.versions.size
        @repository = @project.repository
        if @version_count.zero?
          @versions = []
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_version has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def find_version
        @version_count = @project.versions.size
        @repository = @project.repository
        if @version_count.zero?
          @versions = []
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 1 hr to fix

      Method load_repo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def load_repo
          raise ActiveRecord::RecordNotFound unless current_host.present?
          full_name = [params[:owner], params[:name]].join('/')
          @repository = Repository.host(current_host).where('lower(full_name) = ?', full_name.downcase).first
          raise ActiveRecord::RecordNotFound if @repository.nil?
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status