librenms/librenms

View on GitHub
LibreNMS/Alert/AlertDB.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function genSQLOld has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public static function genSQLOld($rule)
    {
        $rule = AlertUtil::runMacros($rule);
        if (empty($rule)) {
            //Cannot resolve Macros due to recursion. Rule is invalid.
Severity: Minor
Found in LibreNMS/Alert/AlertDB.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method genSQLOld has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function genSQLOld($rule)
    {
        $rule = AlertUtil::runMacros($rule);
        if (empty($rule)) {
            //Cannot resolve Macros due to recursion. Rule is invalid.
Severity: Minor
Found in LibreNMS/Alert/AlertDB.php - About 2 hrs to fix

    The method genSQLOld() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
    Open

        public static function genSQLOld($rule)
        {
            $rule = AlertUtil::runMacros($rule);
            if (empty($rule)) {
                //Cannot resolve Macros due to recursion. Rule is invalid.
    Severity: Minor
    Found in LibreNMS/Alert/AlertDB.php by phpmd

    Since: PHPMD 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example:

    // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

    Source: http://phpmd.org/rules/codesize.txt

    The method genSQL has a boolean flag argument $query_builder, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public static function genSQL($rule, $query_builder = false)
    Severity: Minor
    Found in LibreNMS/Alert/AlertDB.php by phpmd

    Since: PHPMD 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example:

    class Foo {
          public function bar($flag = true) {
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method genSQLOld uses an else expression. Else is never necessary and you can simplify the code to work without else.
    Open

                        } else {
                            [$tmp,$new] = explode('.', $glue);
                            $qry .= $tmp . '.' . $last . ' && ' . $tmp . '.' . $new . ' = ';
                            $last = $new;
                        }
    Severity: Minor
    Found in LibreNMS/Alert/AlertDB.php by phpmd

    Since: PHPMD 1.4.0

    An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example:

    class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method genSQL uses an else expression. Else is never necessary and you can simplify the code to work without else.
    Open

            } else {
                return self::genSQLOld($rule);
            }
    Severity: Minor
    Found in LibreNMS/Alert/AlertDB.php by phpmd

    Since: PHPMD 1.4.0

    An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example:

    class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    Avoid variables with short names like $x. Configured minimum length is 3.
    Open

            $x = sizeof($tables) - 1;
    Severity: Minor
    Found in LibreNMS/Alert/AlertDB.php by phpmd

    Since: PHPMD 0.2

    Detects when a field, local, or parameter has a very short name.

    Example:

    class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

    Source: http://phpmd.org/rules/naming.txt

    Avoid variables with short names like $i. Configured minimum length is 3.
    Open

            $i = 0;
    Severity: Minor
    Found in LibreNMS/Alert/AlertDB.php by phpmd

    Since: PHPMD 0.2

    Detects when a field, local, or parameter has a very short name.

    Example:

    class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

    Source: http://phpmd.org/rules/naming.txt

    There are no issues that match your filters.

    Category
    Status