librenms/librenms

View on GitHub
LibreNMS/Alert/AlertRules.php

Summary

Maintainability
C
1 day
Test Coverage

Function runRules has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

    public function runRules($device_id)
    {

        //Check to see if under maintenance
        if (AlertUtil::isMaintenance($device_id) > 0) {
Severity: Minor
Found in LibreNMS/Alert/AlertRules.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method runRules has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function runRules($device_id)
    {

        //Check to see if under maintenance
        if (AlertUtil::isMaintenance($device_id) > 0) {
Severity: Major
Found in LibreNMS/Alert/AlertRules.php - About 3 hrs to fix

    The method runRules() has an NPath complexity of 3700. The configured NPath complexity threshold is 200.
    Open

        public function runRules($device_id)
        {
    
            //Check to see if under maintenance
            if (AlertUtil::isMaintenance($device_id) > 0) {
    Severity: Minor
    Found in LibreNMS/Alert/AlertRules.php by phpmd

    Since: PHPMD 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example:

    class Foo {
          function bar() {
              // lots of complicated code
          }
      }

    Source: http://phpmd.org/rules/codesize.txt

    The method runRules() has a Cyclomatic Complexity of 24. The configured cyclomatic complexity threshold is 10.
    Open

        public function runRules($device_id)
        {
    
            //Check to see if under maintenance
            if (AlertUtil::isMaintenance($device_id) > 0) {
    Severity: Minor
    Found in LibreNMS/Alert/AlertRules.php by phpmd

    Since: PHPMD 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example:

    // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

    Source: http://phpmd.org/rules/codesize.txt

    The method runRules uses an else expression. Else is never necessary and you can simplify the code to work without else.
    Open

                    } else {
                        if (dbInsert(['state' => AlertState::RECOVERED, 'device_id' => $device_id, 'rule_id' => $rule['id']], 'alert_log')) {
                            if (is_null($current_state)) {
                                dbInsert(['state' => AlertState::RECOVERED, 'device_id' => $device_id, 'rule_id' => $rule['id'], 'open' => 1, 'alerted' => 0], 'alerts');
                            } else {
    Severity: Minor
    Found in LibreNMS/Alert/AlertRules.php by phpmd

    Since: PHPMD 1.4.0

    An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example:

    class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method runRules uses an else expression. Else is never necessary and you can simplify the code to work without else.
    Open

                            } else {
                                dbUpdate(['state' => AlertState::ACTIVE, 'open' => 1, 'timestamp' => Carbon::now()], 'alerts', 'device_id = ? && rule_id = ?', [$device_id, $rule['id']]);
                            }
    Severity: Minor
    Found in LibreNMS/Alert/AlertRules.php by phpmd

    Since: PHPMD 1.4.0

    An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example:

    class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method runRules uses an else expression. Else is never necessary and you can simplify the code to work without else.
    Open

                } else {
                    $inv = false;
                }
    Severity: Minor
    Found in LibreNMS/Alert/AlertRules.php by phpmd

    Since: PHPMD 1.4.0

    An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example:

    class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method runRules uses an else expression. Else is never necessary and you can simplify the code to work without else.
    Open

                    } else {
                        $extra = gzcompress(json_encode(['contacts' => AlertUtil::getContacts($qry), 'rule'=>$qry]), 9);
                        if (dbInsert(['state' => AlertState::ACTIVE, 'device_id' => $device_id, 'rule_id' => $rule['id'], 'details' => $extra], 'alert_log')) {
                            if (is_null($current_state)) {
                                dbInsert(['state' => AlertState::ACTIVE, 'device_id' => $device_id, 'rule_id' => $rule['id'], 'open' => 1, 'alerted' => 0], 'alerts');
    Severity: Minor
    Found in LibreNMS/Alert/AlertRules.php by phpmd

    Since: PHPMD 1.4.0

    An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example:

    class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method runRules uses an else expression. Else is never necessary and you can simplify the code to work without else.
    Open

                } else {
                    if (! is_null($current_state) && $current_state == AlertState::RECOVERED) {
                        c_echo('Status: %bNOCHG');
                    } else {
                        if (dbInsert(['state' => AlertState::RECOVERED, 'device_id' => $device_id, 'rule_id' => $rule['id']], 'alert_log')) {
    Severity: Minor
    Found in LibreNMS/Alert/AlertRules.php by phpmd

    Since: PHPMD 1.4.0

    An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example:

    class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method runRules uses an else expression. Else is never necessary and you can simplify the code to work without else.
    Open

                            } else {
                                dbUpdate(['state' => AlertState::RECOVERED, 'open' => 1, 'note' => '', 'timestamp' => Carbon::now()], 'alerts', 'device_id = ? && rule_id = ?', [$device_id, $rule['id']]);
                            }
    Severity: Minor
    Found in LibreNMS/Alert/AlertRules.php by phpmd

    Since: PHPMD 1.4.0

    An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example:

    class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    The method runRules uses an else expression. Else is never necessary and you can simplify the code to work without else.
    Open

                } else {
                    $doalert = false;
                }
    Severity: Minor
    Found in LibreNMS/Alert/AlertRules.php by phpmd

    Since: PHPMD 1.4.0

    An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example:

    class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

    Source: http://phpmd.org/rules/cleancode.txt

    There are no issues that match your filters.

    Category
    Status