librenms/librenms

View on GitHub
LibreNMS/Alert/Transport/Gitlab.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method contactGitlab has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function contactGitlab($obj, $opts)
    {
        // Don't create tickets for resolutions
        if ($obj['state'] != AlertState::CLEAR) {
            $device = device_by_id_cache($obj['device_id']); // for event logging
Severity: Minor
Found in LibreNMS/Alert/Transport/Gitlab.php - About 1 hr to fix

    Method configTemplate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function configTemplate()
        {
            return [
                'config' => [
                    [
    Severity: Minor
    Found in LibreNMS/Alert/Transport/Gitlab.php - About 1 hr to fix

      The method contactGitlab uses an else expression. Else is never necessary and you can simplify the code to work without else.
      Open

                  } else {
                      d_echo('Gitlab connection error: ' . serialize($ret));
      
                      return false;
                  }
      Severity: Minor
      Found in LibreNMS/Alert/Transport/Gitlab.php by phpmd

      Since: PHPMD 1.4.0

      An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example:

      class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

      Source: http://phpmd.org/rules/cleancode.txt

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function configTemplate()
          {
              return [
                  'config' => [
                      [
      Severity: Major
      Found in LibreNMS/Alert/Transport/Gitlab.php and 1 other location - About 2 hrs to fix
      LibreNMS/Alert/Transport/Syslog.php on lines 137..166

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if ($code == 200) {
                      $gitlabout = json_decode($ret, true);
                      d_echo('Created Gitlab issue ' . $gitlabout['key'] . ' for ' . $device);
      
                      return true;
      Severity: Major
      Found in LibreNMS/Alert/Transport/Gitlab.php and 1 other location - About 1 hr to fix
      LibreNMS/Alert/Transport/Jira.php on lines 81..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status