librenms/librenms

Method parseRuleToQuery has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function parseRuleToQuery($query, $rule, $condition)
    {
        [$field, $op, $value] = $this->expandRule($rule);

        switch ($op) {

Avoid too many return statements within this method.

Open

        return $query;

Avoid too many return statements within this method.

Open

                return $query->whereBetween($field, $value, $condition, $op == 'not_between');

Avoid too many return statements within this method.

Open

                return $query->where($field, self::$operators[$op], '');

Avoid too many return statements within this method.

Open

                return $query->whereNull($field, $condition, $op == 'is_not_null');

Avoid too many return statements within this method.

Open

                    return $query->whereIn($field, $values, $condition, $op == 'not_in');

The method parseRuleToQuery() has a Cyclomatic Complexity of 24. The configured cyclomatic complexity threshold is 10.

Open

    protected function parseRuleToQuery($query, $rule, $condition)
    {
        [$field, $op, $value] = $this->expandRule($rule);

        switch ($op) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Avoid using undefined variables such as '::$operators' which will lead to PHP notices.

Open

                return $query->where($field, self::$operators[$op], $value, $condition);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '::$operators' which will lead to PHP notices.

Open

                return $query->where($field, self::$operators[$op], "$value%", $condition);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '::$operators' which will lead to PHP notices.

Open

                return $query->where($field, self::$operators[$op], "%$value", $condition);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '::$operators' which will lead to PHP notices.

Open

                return $query->where($field, self::$operators[$op], '');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '::$operators' which will lead to PHP notices.

Open

                return $query->where($field, self::$operators[$op], "%$value%", $condition);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

The method parseGroupToQuery uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                } else {
                    $this->parseRuleToQuery($query, $group_rule, $rule['condition']);
                }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid unused local variables such as '$leftKey'.

Open

                [$leftTable, $leftKey] = explode('.', $left);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$rightKey'.

Open

                [$rightTable, $rightKey] = explode('.', $right);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid variables with short names like $op. Configured minimum length is 3.

Open

        [$field, $op, $value] = $this->expandRule($rule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $op. Configured minimum length is 3.

Open

        $op = $rule['operator'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}