librenms/librenms

View on GitHub
LibreNMS/Data/Store/Prometheus.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method put has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function put($device, $measurement, $tags, $fields)
    {
        $stat = Measurement::start('put');
        // skip if needed
        if (! $this->enabled) {
Severity: Minor
Found in LibreNMS/Data/Store/Prometheus.php - About 1 hr to fix

    Function put has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function put($device, $measurement, $tags, $fields)
        {
            $stat = Measurement::start('put');
            // skip if needed
            if (! $this->enabled) {
    Severity: Minor
    Found in LibreNMS/Data/Store/Prometheus.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method put() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function put($device, $measurement, $tags, $fields)
        {
            $stat = Measurement::start('put');
            // skip if needed
            if (! $this->enabled) {
    Severity: Minor
    Found in LibreNMS/Data/Store/Prometheus.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The property $base_uri is not named in camelCase.
    Open

    class Prometheus extends BaseDatastore
    {
        private $client;
        private $base_uri;
    
    
    Severity: Minor
    Found in LibreNMS/Data/Store/Prometheus.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
        protected $property_name;
    }

    Source

    There are no issues that match your filters.

    Category
    Status