Sign upLogin

librenms/librenms

View on GitHub
Star
LibreNMS/Exceptions/JsonAppMissingKeysException.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $output, $parsed_json = [], $code = 0, Throwable $previous = null)
Severity: Minor
Found in LibreNMS/Exceptions/JsonAppMissingKeysException.php - About 35 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    <?php

namespace LibreNMS\Exceptions;

use Throwable;
    Severity: Major
    Found in LibreNMS/Exceptions/JsonAppMissingKeysException.php and 2 other locations - About 1 hr to fix
    LibreNMS/Exceptions/JsonAppExtendErroredException.php on lines 1..28
    LibreNMS/Exceptions/JsonAppWrongVersionException.php on lines 1..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    The property $parsed_json is not named in camelCase.
    Open

    class JsonAppMissingKeysException extends JsonAppException
{
    private $output;
    private $parsed_json;
    Severity: Minor
    Found in LibreNMS/Exceptions/JsonAppMissingKeysException.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    There are no issues that match your filters.

    Category
    Status