librenms/librenms

Method rewriteHardware has 605 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function rewriteHardware()
    {
        $rewrite_ironware_hardware = [
            'snFIWGSwitch' => 'Stackable FastIron workgroup',
            'snFIBBSwitch' => 'Stackable FastIron backbone',

File Ironware.php has 620 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/**
 * Ironware.php
 *
 * Brocade Ironware OS

The method rewriteHardware() has 610 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    private function rewriteHardware()
    {
        $rewrite_ironware_hardware = [
            'snFIWGSwitch' => 'Stackable FastIron workgroup',
            'snFIBBSwitch' => 'Stackable FastIron backbone',

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long variable names like $rewrite_ironware_hardware. Keep variable name length under 20.

Open

        $rewrite_ironware_hardware = [

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}