librenms/librenms

View on GitHub
includes/polling/functions.inc.php

Summary

Maintainability
F
5 days
Test Coverage

Function poll_sensor has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

function poll_sensor($device, $class)
{
    global $agent_sensors;

    $sensors = [];
Severity: Minor
Found in includes/polling/functions.inc.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File functions.inc.php has 371 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

use Illuminate\Support\Str;
use LibreNMS\Enum\Severity;
use LibreNMS\Exceptions\JsonAppBase64DecodeException;
Severity: Minor
Found in includes/polling/functions.inc.php - About 4 hrs to fix

    Method update_application has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function update_application($app, $response, $metrics = [], $status = '')
    {
        if (! $app) {
            d_echo('$app does not exist, could not update');
    
    
    Severity: Major
    Found in includes/polling/functions.inc.php - About 4 hrs to fix

      Function update_application has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

      function update_application($app, $response, $metrics = [], $status = '')
      {
          if (! $app) {
              d_echo('$app does not exist, could not update');
      
      
      Severity: Minor
      Found in includes/polling/functions.inc.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method record_sensor_data has 91 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function record_sensor_data($device, $all_sensors)
      {
          $supported_sensors = [
              'airflow' => 'cfm',
              'ber' => '',
      Severity: Major
      Found in includes/polling/functions.inc.php - About 3 hrs to fix

        Function record_sensor_data has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

        function record_sensor_data($device, $all_sensors)
        {
            $supported_sensors = [
                'airflow' => 'cfm',
                'ber' => '',
        Severity: Minor
        Found in includes/polling/functions.inc.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function json_app_get has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

        function json_app_get($device, $extend, $min_version = 1)
        {
            $output = snmp_get($device, 'nsExtendOutputFull.' . \LibreNMS\Util\Oid::ofString($extend), '-Oqv', 'NET-SNMP-EXTEND-MIB');
        
            // save for returning if not JSON
        Severity: Minor
        Found in includes/polling/functions.inc.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method poll_sensor has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function poll_sensor($device, $class)
        {
            global $agent_sensors;
        
            $sensors = [];
        Severity: Major
        Found in includes/polling/functions.inc.php - About 2 hrs to fix

          Method json_app_get has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function json_app_get($device, $extend, $min_version = 1)
          {
              $output = snmp_get($device, 'nsExtendOutputFull.' . \LibreNMS\Util\Oid::ofString($extend), '-Oqv', 'NET-SNMP-EXTEND-MIB');
          
              // save for returning if not JSON
          Severity: Minor
          Found in includes/polling/functions.inc.php - About 1 hr to fix

            Function data_flatten has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            function data_flatten($array, $prefix = '', $joiner = '_')
            {
                $return = [];
                foreach ($array as $key => $value) {
                    if (is_array($value)) {
            Severity: Minor
            Found in includes/polling/functions.inc.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Consider simplifying this complex logical expression.
            Open

                    if ($sensor['sensor_limit_low'] != '' && $prev_sensor_value > $sensor['sensor_limit_low'] && $sensor_value < $sensor['sensor_limit_low'] && $sensor['sensor_alert'] == 1) {
                        echo 'Alerting for ' . $device['hostname'] . ' ' . $sensor['sensor_descr'] . "\n";
                        log_event("$class under threshold: $sensor_value $unit (< {$sensor['sensor_limit_low']} $unit)", $device, $sensor['sensor_class'], 4, $sensor['sensor_id']);
                    } elseif ($sensor['sensor_limit'] != '' && $prev_sensor_value < $sensor['sensor_limit'] && $sensor_value > $sensor['sensor_limit'] && $sensor['sensor_alert'] == 1) {
                        echo 'Alerting for ' . $device['hostname'] . ' ' . $sensor['sensor_descr'] . "\n";
            Severity: Major
            Found in includes/polling/functions.inc.php - About 1 hr to fix

              The function poll_sensor() has an NPath complexity of 360. The configured NPath complexity threshold is 200.
              Open

              function poll_sensor($device, $class)
              {
                  global $agent_sensors;
              
                  $sensors = [];
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              NPathComplexity

              Since: 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example

              class Foo {
                  function bar() {
                      // lots of complicated code
                  }
              }

              Source https://phpmd.org/rules/codesize.html#npathcomplexity

              The function record_sensor_data() has 107 lines of code. Current threshold is set to 100. Avoid really long methods.
              Open

              function record_sensor_data($device, $all_sensors)
              {
                  $supported_sensors = [
                      'airflow' => 'cfm',
                      'ber' => '',
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              The function update_application() has 129 lines of code. Current threshold is set to 100. Avoid really long methods.
              Open

              function update_application($app, $response, $metrics = [], $status = '')
              {
                  if (! $app) {
                      d_echo('$app does not exist, could not update');
              
              
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              The function json_app_get() has an NPath complexity of 1280. The configured NPath complexity threshold is 200.
              Open

              function json_app_get($device, $extend, $min_version = 1)
              {
                  $output = snmp_get($device, 'nsExtendOutputFull.' . \LibreNMS\Util\Oid::ofString($extend), '-Oqv', 'NET-SNMP-EXTEND-MIB');
              
                  // save for returning if not JSON
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              NPathComplexity

              Since: 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example

              class Foo {
                  function bar() {
                      // lots of complicated code
                  }
              }

              Source https://phpmd.org/rules/codesize.html#npathcomplexity

              The function record_sensor_data() has an NPath complexity of 2917. The configured NPath complexity threshold is 200.
              Open

              function record_sensor_data($device, $all_sensors)
              {
                  $supported_sensors = [
                      'airflow' => 'cfm',
                      'ber' => '',
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              NPathComplexity

              Since: 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example

              class Foo {
                  function bar() {
                      // lots of complicated code
                  }
              }

              Source https://phpmd.org/rules/codesize.html#npathcomplexity

              The function update_application() has an NPath complexity of 2460. The configured NPath complexity threshold is 200.
              Open

              function update_application($app, $response, $metrics = [], $status = '')
              {
                  if (! $app) {
                      d_echo('$app does not exist, could not update');
              
              
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              NPathComplexity

              Since: 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example

              class Foo {
                  function bar() {
                      // lots of complicated code
                  }
              }

              Source https://phpmd.org/rules/codesize.html#npathcomplexity

              The function update_application() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
              Open

              function update_application($app, $response, $metrics = [], $status = '')
              {
                  if (! $app) {
                      d_echo('$app does not exist, could not update');
              
              
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
              class Foo {
              1   public function example() {
              2       if ($a == $b) {
              3           if ($a1 == $b1) {
                              fiddle();
              4           } elseif ($a2 == $b2) {
                              fiddle();
                          } else {
                              fiddle();
                          }
              5       } elseif ($c == $d) {
              6           while ($c == $d) {
                              fiddle();
                          }
              7        } elseif ($e == $f) {
              8           for ($n = 0; $n < $h; $n++) {
                              fiddle();
                          }
                      } else {
                          switch ($z) {
              9               case 1:
                                  fiddle();
                                  break;
              10              case 2:
                                  fiddle();
                                  break;
              11              case 3:
                                  fiddle();
                                  break;
                              default:
                                  fiddle();
                                  break;
                          }
                      }
                  }
              }

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              The function json_app_get() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
              Open

              function json_app_get($device, $extend, $min_version = 1)
              {
                  $output = snmp_get($device, 'nsExtendOutputFull.' . \LibreNMS\Util\Oid::ofString($extend), '-Oqv', 'NET-SNMP-EXTEND-MIB');
              
                  // save for returning if not JSON
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
              class Foo {
              1   public function example() {
              2       if ($a == $b) {
              3           if ($a1 == $b1) {
                              fiddle();
              4           } elseif ($a2 == $b2) {
                              fiddle();
                          } else {
                              fiddle();
                          }
              5       } elseif ($c == $d) {
              6           while ($c == $d) {
                              fiddle();
                          }
              7        } elseif ($e == $f) {
              8           for ($n = 0; $n < $h; $n++) {
                              fiddle();
                          }
                      } else {
                          switch ($z) {
              9               case 1:
                                  fiddle();
                                  break;
              10              case 2:
                                  fiddle();
                                  break;
              11              case 3:
                                  fiddle();
                                  break;
                              default:
                                  fiddle();
                                  break;
                          }
                      }
                  }
              }

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              The function poll_sensor() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
              Open

              function poll_sensor($device, $class)
              {
                  global $agent_sensors;
              
                  $sensors = [];
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
              class Foo {
              1   public function example() {
              2       if ($a == $b) {
              3           if ($a1 == $b1) {
                              fiddle();
              4           } elseif ($a2 == $b2) {
                              fiddle();
                          } else {
                              fiddle();
                          }
              5       } elseif ($c == $d) {
              6           while ($c == $d) {
                              fiddle();
                          }
              7        } elseif ($e == $f) {
              8           for ($n = 0; $n < $h; $n++) {
                              fiddle();
                          }
                      } else {
                          switch ($z) {
              9               case 1:
                                  fiddle();
                                  break;
              10              case 2:
                                  fiddle();
                                  break;
              11              case 3:
                                  fiddle();
                                  break;
                              default:
                                  fiddle();
                                  break;
                          }
                      }
                  }
              }

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              The function record_sensor_data() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
              Open

              function record_sensor_data($device, $all_sensors)
              {
                  $supported_sensors = [
                      'airflow' => 'cfm',
                      'ber' => '',
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
              class Foo {
              1   public function example() {
              2       if ($a == $b) {
              3           if ($a1 == $b1) {
                              fiddle();
              4           } elseif ($a2 == $b2) {
                              fiddle();
                          } else {
                              fiddle();
                          }
              5       } elseif ($c == $d) {
              6           while ($c == $d) {
                              fiddle();
                          }
              7        } elseif ($e == $f) {
              8           for ($n = 0; $n < $h; $n++) {
                              fiddle();
                          }
                      } else {
                          switch ($z) {
              9               case 1:
                                  fiddle();
                                  break;
              10              case 2:
                                  fiddle();
                                  break;
              11              case 3:
                                  fiddle();
                                  break;
                              default:
                                  fiddle();
                                  break;
                          }
                      }
                  }
              }

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              Avoid using undefined variables such as '$mib' which will lead to PHP notices.
              Open

                          unset($mib);
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              The method poll_sensor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              echo "no agent data!\n";
                              continue;
                          }
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method record_sensor_data uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              $sensor_value = (new UserFuncHelper($sensor_value, $sensor['new_value'], $sensor))->{$sensor['user_func']}();
                          }
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method update_application uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                                  } else {
                                      $prefix = $metric_group . '_';
                                  }
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method data_flatten uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          if (strcmp($prefix, '')) {
                              $key = $prefix . $joiner . $key;
                          }
                          $return[$key] = $value;
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method update_application uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          // should maybe be 'unknown' as state
                          $app->app_state = 'OK';
                      }
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method update_application uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              echo '.';
                          }
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method poll_sensor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          echo "unknown poller type!\n";
                          continue;
                      }//end if
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method poll_sensor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          $sensors[] = $sensor;
                      }
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid unused local variables such as '$sensor_cache'.
              Open

                  $sensor_cache = sensor_precache($device, $class);
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              UnusedLocalVariable

              Since: 0.2

              Detects when a local variable is declared and/or assigned, but not used.

              Example

              class Foo {
                  public function doSomething()
                  {
                      $i = 5; // Unused
                  }
              }

              Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

              Avoid unused parameters such as '$type'.
              Open

              function sensor_precache($device, $type)
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              UnusedFormalParameter

              Since: 0.2

              Avoid passing parameters to methods or constructors and then not using those parameters.

              Example

              class Foo
              {
                  private function bar($howdy)
                  {
                      // $howdy is not used
                  }
              }

              Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

              Avoid unused local variables such as '$mib'.
              Open

                          unset($mib);
              Severity: Minor
              Found in includes/polling/functions.inc.php by phpmd

              UnusedLocalVariable

              Since: 0.2

              Detects when a local variable is declared and/or assigned, but not used.

              Example

              class Foo {
                  public function doSomething()
                  {
                      $i = 5; // Unused
                  }
              }

              Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

              FIXME found
              Open

                      // FIXME also warn when crossing WARN level!
              Severity: Minor
              Found in includes/polling/functions.inc.php by fixme

              FIXME found
              Open

                          // ipmi should probably move here from the ipmi poller file (FIXME)
              Severity: Minor
              Found in includes/polling/functions.inc.php by fixme

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function data_flatten($array, $prefix = '', $joiner = '_')
              {
                  $return = [];
                  foreach ($array as $key => $value) {
                      if (is_array($value)) {
              Severity: Major
              Found in includes/polling/functions.inc.php and 1 other location - About 3 hrs to fix
              scripts/json-app-tool.php on lines 7..25

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 155.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  $supported_sensors = [
                      'airflow' => 'cfm',
                      'ber' => '',
                      'bitrate' => 'bps',
                      'charge' => '%',
              Severity: Major
              Found in includes/polling/functions.inc.php and 1 other location - About 3 hrs to fix
              app/Models/Sensor.php on lines 15..46

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 152.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status