librenms/librenms

View on GitHub
validate.php

Summary

Maintainability
A
0 mins
Test Coverage

Remove error control operator '@' on line 153.
Open

function print_header()
{
    $output = ob_get_clean();
    @ob_end_clean();

Severity: Minor
Found in validate.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 150 and the first side effect is on line 20.
Open

#!/usr/bin/env php
Severity: Minor
Found in validate.php by phpcodesniffer

There are no issues that match your filters.

Category
Status