Sign upLogin

lipp/node-jet

View on GitHub
Star

Showing 29 of 29 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  createConnectPromise = () => {
    this.connectPromise = new Promise<void>((resolve, reject) => {
      this.resolveConnect = resolve
      this.rejectConnect = reject
    })
Severity: Major
Found in src/2_jsonrpc/index.ts and 1 other location - About 1 hr to fix
src/2_jsonrpc/index.ts on lines 89..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if(!_.isEqual(res,req.res)){
      throw new Error(`\n Expected:${JSON.stringify(res)} \n Received ${JSON.stringify(req.res)} `)
     }
Severity: Major
Found in bench/validation.js and 1 other location - About 1 hr to fix
bench/validation.js on lines 71..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  createDisconnectPromise = () => {
    this.disconnectPromise = new Promise<void>((resolve, reject) => {
      this.resolveDisconnect = resolve
      this.rejectDisconnect = reject
    })
Severity: Major
Found in src/2_jsonrpc/index.ts and 1 other location - About 1 hr to fix
src/2_jsonrpc/index.ts on lines 98..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function addEventListener has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  addEventListener(
    method: string | symbol,
    // eslint-disable-next-line @typescript-eslint/no-explicit-any
    listener: { (...args: any[]): void; call?: any }
  ) {
Severity: Minor
Found in src/1_socket/message-socket.ts - About 1 hr to fix

    Function edgePos has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var edgePos = () => {
  var x = Math.random()
  var size = 0.8
  if (Math.random() > 0.7) {
    size = 0.4
    Severity: Minor
    Found in examples/balls/server/index.ts - About 1 hr to fix

      Function renderBall has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var renderBall = (ball: ballEvent) => {
  if (ball.event === 'Add') {
    try {
      balls[ball.path] = ball
      svgContainer
      Severity: Minor
      Found in examples/balls/client/index.ts - About 1 hr to fix

        Function createPathMatcher has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export const createPathMatcher = (options: FetchParams) => {
  if (!options.path) {
    return () => true
  }
  const po = options.path
        Severity: Minor
        Found in src/3_jet/daemon/path_matcher.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

              return msg as T
        Severity: Major
        Found in src/3_jet/messages.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return msg as T
          Severity: Major
          Found in src/3_jet/messages.ts - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language