livepeer/livepeerjs

View on GitHub

Showing 402 of 411 total issues

File index.tsx has 627 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { useState, useEffect } from "react";
import { ThreeBoxSpace } from "../../@types";
import Box from "../Box";
import Flex from "../Flex";
import Camera from "../../public/img/camera.svg";
Severity: Major
Found in packages/explorer-2.0/components/EditProfile/index.tsx - About 1 day to fix

Function render has 263 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { url } = this.props;
    const {
      live,
      modal,
Severity: Major
Found in packages/player/src/views/Channel/index.js - About 1 day to fix

File index.tsx has 604 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Box from "../Box";
import Flex from "../Flex";
import { abbreviateNumber } from "../../lib/utils";
import { useRouter } from "next/router";
import { useQuery } from "@apollo/client";
Severity: Major
Found in packages/explorer-2.0/components/HistoryView/index.tsx - About 1 day to fix

File PerformanceTable.tsx has 582 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Box from "../Box";
import Flex from "../Flex";
import { forwardRef, useMemo } from "react";
import { useTable, useFilters, useSortBy, usePagination } from "react-table";
import Help from "../../public/img/help.svg";
Severity: Major
Found in packages/explorer-2.0/components/Orchestrators/PerformanceTable.tsx - About 1 day to fix

Function Index has 247 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Index = () => {
  const isVisible = usePageVisibility();
  const { data: modalData } = useQuery(GET_ROUND_MODAL_STATUS);
  const pollInterval = 60000;
  const {
Severity: Major
Found in packages/explorer-2.0/components/RoundStatus/index.tsx - About 1 day to fix

rpc has 67 functions (exceeds 20 allowed). Consider refactoring.
Open

  const rpc = {
    /**
     * Gets the ENS name for an address. This is known as a reverse lookup.
     * Unfortunately, users must explicitly set their own resolver.
     * So most of the time, this method just returns an empty string
Severity: Major
Found in packages/sdk/src/index.js - About 1 day to fix

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  function DefaultColumnFilter({ column: { filterValue, setFilter } }) {
    return (
      <Flex
        css={{
          alignItems: "center",
packages/explorer-2.0/components/Orchestrators/PerformanceTable.tsx on lines 33..66
packages/explorer-2.0/components/Orchestrators/StakingTable.tsx on lines 36..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 227.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  function DefaultColumnFilter({ column: { filterValue, setFilter } }) {
    return (
      <Flex
        css={{
          alignItems: "center",
packages/explorer-2.0/components/OrchestratorPayouts/Table.tsx on lines 33..66
packages/explorer-2.0/components/Orchestrators/PerformanceTable.tsx on lines 33..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 227.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  function DefaultColumnFilter({ column: { filterValue, setFilter } }) {
    return (
      <Flex
        css={{
          alignItems: "center",
packages/explorer-2.0/components/OrchestratorPayouts/Table.tsx on lines 33..66
packages/explorer-2.0/components/Orchestrators/StakingTable.tsx on lines 36..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 227.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                      case "Orchestrator":
                        const active =
                          cell.row.values.activationRound <= currentRound.id &&
                          cell.row.values.deactivationRound > currentRound.id;
                        return (
packages/explorer-2.0/components/Orchestrators/StakingTable.tsx on lines 340..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 224.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                      case "Orchestrator":
                        const active =
                          cell.row.values.activationRound <= currentRound.id &&
                          cell.row.values.deactivationRound > currentRound.id;
                        return (
packages/explorer-2.0/components/Orchestrators/PerformanceTable.tsx on lines 346..372

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 224.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function createSchema has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
Open

const createSchema = async () => {
  const executor = async ({ document, variables }) => {
    const query = print(document);
    const fetchResult = await fetch(process.env.NEXT_PUBLIC_SUBGRAPH, {
      method: "POST",
Severity: Minor
Found in packages/explorer-2.0/apollo/createSchema.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Account has 227 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Account = () => {
  const context = useWeb3React();
  const { width } = useWindowSize();
  const isVisible = usePageVisibility();
  const router = useRouter();
Severity: Major
Found in packages/explorer-2.0/pages/accounts/[account]/[slug].tsx - About 1 day to fix

File bondingManager.ts has 543 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { store } from "@graphprotocol/graph-ts";

// Import event types from the registrar contract ABIs
import {
  BondingManager,
Severity: Major
Found in packages/subgraph/src/mappings/bondingManager.ts - About 1 day to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    <CopyToClipboard
                      text={message.replace(/<br ?\/?>/g, "\n")}
                      onCopy={() => setCopied(true)}>
                      <Flex
                        data-for="copyMessage"
Severity: Major
Found in packages/explorer-2.0/components/EditProfile/index.tsx and 1 other location - About 1 day to fix
packages/explorer-2.0/components/VotingWidget/index.tsx on lines 319..368

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 211.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              <CopyToClipboard
                text={data.poll.id}
                onCopy={() => setCopied(true)}
              >
                <Flex
Severity: Major
Found in packages/explorer-2.0/components/VotingWidget/index.tsx and 1 other location - About 1 day to fix
packages/explorer-2.0/components/EditProfile/index.tsx on lines 525..572

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 211.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getChartData has 216 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function getChartData(_obj?, _args?, _ctx?, _info?) {
  const data = {
    dayData: [],
    weeklyData: [],
    totalVolumeUSD: 0,
Severity: Major
Found in packages/explorer-2.0/apollo/resolvers/Query.tsx - About 1 day to fix

Function Index has 211 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Index = () => {
  const { active, account, connector, error, activate } = useWeb3React();
  const [walletView, setWalletView] = useState(WALLET_VIEWS.ACCOUNT);
  const [pendingWallet, setPendingWallet] = useState<
    AbstractConnector | undefined
Severity: Major
Found in packages/explorer-2.0/components/WalletModal/index.tsx - About 1 day to fix

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                scores: {
                  global: avg(metrics[key], "score") * 10000,
                  fra: (metrics[key].FRA?.score || 0) * 10000,
                  mdw: (metrics[key].MDW?.score || 0) * 10000,
                  sin: (metrics[key].SIN?.score || 0) * 10000,
Severity: Major
Found in packages/explorer-2.0/apollo/createSchema.ts and 2 other locations - About 1 day to fix
packages/explorer-2.0/apollo/createSchema.ts on lines 381..390
packages/explorer-2.0/apollo/createSchema.ts on lines 391..400

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                roundTripScores: {
                  global: avg(metrics[key], "round_trip_score") * 10000,
                  fra: (metrics[key].FRA?.round_trip_score || 0) * 10000,
                  mdw: (metrics[key].MDW?.round_trip_score || 0) * 10000,
                  sin: (metrics[key].SIN?.round_trip_score || 0) * 10000,
Severity: Major
Found in packages/explorer-2.0/apollo/createSchema.ts and 2 other locations - About 1 day to fix
packages/explorer-2.0/apollo/createSchema.ts on lines 371..380
packages/explorer-2.0/apollo/createSchema.ts on lines 381..390

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language