Sign upLogin

livepeer/livepeerjs

View on GitHub
Star

Showing 402 of 411 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                successRates: {
                  global: avg(metrics[key], "success_rate") * 100,
                  fra: (metrics[key].FRA?.success_rate || 0) * 100,
                  mdw: (metrics[key].MDW?.success_rate || 0) * 100,
                  sin: (metrics[key].SIN?.success_rate || 0) * 100,
Severity: Major
Found in packages/explorer-2.0/apollo/createSchema.ts and 2 other locations - About 1 day to fix
packages/explorer-2.0/apollo/createSchema.ts on lines 371..380
packages/explorer-2.0/apollo/createSchema.ts on lines 391..400

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File index.js has 484 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component, ReactChildren, ReactElement } from "react";
import PropTypes from "prop-types";
import { Player, BigPlayButton, ControlBar } from "video-react";
import GlobalStyles from "./styles";
import Hls from "hls.js";
Severity: Minor
Found in packages/chroma/src/VideoPlayer/index.js - About 7 hrs to fix

Function Voting has 180 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Voting = () => {
  const isVisible = usePageVisibility();
  const pollInterval = 20000;
  const [polls, setPolls] = useState([]);
  const [loading, setLoading] = useState(true);
Severity: Major
Found in packages/explorer-2.0/pages/voting/index.tsx - About 7 hrs to fix

File Table.tsx has 465 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Box from "../Box";
import Flex from "../Flex";
import { useMemo } from "react";
import { useTable, useFilters, useSortBy, usePagination } from "react-table";
import matchSorter from "match-sorter";
Severity: Minor
Found in packages/explorer-2.0/components/OrchestratorPayouts/Table.tsx - About 7 hrs to fix

Function Index has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

const Index = ({ threeBoxSpace, refetch, account }: Props) => {
  const context = useWeb3React();
  const { register, handleSubmit, formState, watch } = useForm();
  const [previewImage, setPreviewImage] = useState(null);
  const [saving, setSaving] = useState(false);
Severity: Minor
Found in packages/explorer-2.0/components/EditProfile/index.tsx - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File [poll].tsx has 453 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Box from "../../components/Box";
import Flex from "../../components/Flex";
import { getLayout } from "../../layouts/main";
import fm from "front-matter";
import IPFS from "ipfs-mini";
Severity: Minor
Found in packages/explorer-2.0/pages/voting/[poll].tsx - About 6 hrs to fix

File index.tsx has 446 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Box from "../Box";
import Flex from "../Flex";
import Utils from "web3-utils";
import { abbreviateNumber } from "../../lib/utils";
import VoteButton from "../VoteButton";
Severity: Minor
Found in packages/explorer-2.0/components/VotingWidget/index.tsx - About 6 hrs to fix

Function renderTooltip has 166 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function renderTooltip(title) {
    switch (title) {
      case "Stake":
        return (
          <>
Severity: Major
Found in packages/explorer-2.0/components/Orchestrators/StakingTable.tsx - About 6 hrs to fix

File main.tsx has 431 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Box from "../components/Box";
import Flex from "../components/Flex";
import React, { useState, useEffect, useRef } from "react";
import Head from "next/head";
import Drawer from "../components/Drawer";
Severity: Minor
Found in packages/explorer-2.0/layouts/main.tsx - About 6 hrs to fix

Consider simplifying this complex logical expression.
Open

            if (transcoders.filter((a) => a.id === key).length > 0) {
              performanceMetrics.push({
                id: key,
                scores: {
                  global: avg(metrics[key], "score") * 10000,
Severity: Critical
Found in packages/explorer-2.0/apollo/createSchema.ts - About 6 hrs to fix

File index.tsx has 407 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { NetworkStatus, useQuery, gql } from "@apollo/client";
import Box from "../Box";
import Flex from "../Flex";
import PerformanceTable from "./PerformanceTable";
import StakingTable from "./StakingTable";
Severity: Minor
Found in packages/explorer-2.0/components/Orchestrators/index.tsx - About 5 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    async getPendingFees(addr: string, endRound: string): Promise<string> {
      try {
        const address = await resolveAddress(rpc.getENSAddress, addr);
        if (!endRound) {
          const currentRound = await rpc.getCurrentRound();
Severity: Major
Found in packages/sdk/src/index.js and 1 other location - About 5 hrs to fix
packages/sdk/src/index.js on lines 1321..1337

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    async getPendingStake(addr: string, endRound: string): Promise<string> {
      try {
        const address = await resolveAddress(rpc.getENSAddress, addr);
        if (!endRound) {
          const currentRound = await rpc.getCurrentRound();
Severity: Major
Found in packages/sdk/src/index.js and 1 other location - About 5 hrs to fix
packages/sdk/src/index.js on lines 1351..1367

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              <Card
                css={{ flex: 1, mb: 0 }}
                title={
                  <Flex css={{ alignItems: "center" }}>
                    <Box css={{ color: "$muted" }}>
Severity: Major
Found in packages/explorer-2.0/pages/voting/[poll].tsx and 1 other location - About 5 hrs to fix
packages/explorer-2.0/pages/voting/[poll].tsx on lines 253..318

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              <Card
                css={{ flex: 1, mb: 0 }}
                title={
                  <Flex css={{ alignItems: "center" }}>
                    <Box css={{ color: "$muted" }}>
Severity: Major
Found in packages/explorer-2.0/pages/voting/[poll].tsx and 1 other location - About 5 hrs to fix
packages/explorer-2.0/pages/voting/[poll].tsx on lines 320..372

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function WhatsNew has 136 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const WhatsNew = () => {
  const [changeFeedData, setChangeFeedData] = useState(null);

  useEffect(() => {
    const apolloFetch = createApolloFetch({
Severity: Major
Found in packages/explorer-2.0/pages/whats-new.tsx - About 5 hrs to fix

File createSchema.ts has 390 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import fetch from "isomorphic-unfetch";
import Utils from "web3-utils";
import { createApolloFetch } from "apollo-fetch";
import { applyMiddleware } from "graphql-middleware";
import graphqlFields from "graphql-fields";
Severity: Minor
Found in packages/explorer-2.0/apollo/createSchema.ts - About 5 hrs to fix

File index.js has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component } from "react";
import { Redirect } from "react-router-dom";
import styled from "styled-components";
import {
  Code as CodeIcon,
Severity: Minor
Found in packages/player/src/views/Channel/index.js - About 4 hrs to fix

File create-poll.tsx has 372 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Box from "../../components/Box";
import Flex from "../../components/Flex";
import { getLayout } from "../../layouts/main";
import IPFS from "ipfs-mini";
import fm from "front-matter";
Severity: Minor
Found in packages/explorer-2.0/pages/voting/create-poll.tsx - About 4 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const Step3 = ({ goTo, nextStep }) => {
  const GET_UNISWAP_MODAL_STATUS = gql`
    {
      uniswapModalOpen @client
    }
Severity: Major
Found in packages/explorer-2.0/components/StakingGuide/Step3.tsx and 1 other location - About 4 hrs to fix
packages/explorer-2.0/components/StakingGuide/Step1.tsx on lines 4..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language