livepeer/livepeerjs

View on GitHub
packages/explorer-2.0/components/WalletModal/index.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function Index has 211 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Index = () => {
  const { active, account, connector, error, activate } = useWeb3React();
  const [walletView, setWalletView] = useState(WALLET_VIEWS.ACCOUNT);
  const [pendingWallet, setPendingWallet] = useState<
    AbstractConnector | undefined
Severity: Major
Found in packages/explorer-2.0/components/WalletModal/index.tsx - About 1 day to fix

Function getOptions has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function getOptions() {
    const isMetamask = window["ethereum"] && window["ethereum"].isMetaMask;
    return Object.keys(SUPPORTED_WALLETS).map((key) => {
      const option = SUPPORTED_WALLETS[key];

Severity: Major
Found in packages/explorer-2.0/components/WalletModal/index.tsx - About 2 hrs to fix

Function getModalContent has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function getModalContent() {
    if (account && walletView === WALLET_VIEWS.ACCOUNT) {
      return (
        <AccountDetails
          onClose={close}
Severity: Major
Found in packages/explorer-2.0/components/WalletModal/index.tsx - About 2 hrs to fix

Function Index has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const Index = () => {
  const { active, account, connector, error, activate } = useWeb3React();
  const [walletView, setWalletView] = useState(WALLET_VIEWS.ACCOUNT);
  const [pendingWallet, setPendingWallet] = useState<
    AbstractConnector | undefined
Severity: Minor
Found in packages/explorer-2.0/components/WalletModal/index.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

    if (
      data.walletModalOpen &&
      ((active && !activePrevious) ||
        (connector && connector !== connectorPrevious && !error))
    ) {
Severity: Major
Found in packages/explorer-2.0/components/WalletModal/index.tsx - About 40 mins to fix

Consider simplifying this complex logical expression.
Open

        if (!window["web3"] && !window["ethereum"] && option.mobile) {
          return (
            <Option
              onClick={() => {
                option.connector !== connector &&
Severity: Major
Found in packages/explorer-2.0/components/WalletModal/index.tsx - About 40 mins to fix

Avoid too many return statements within this function.
Open

          return null;
Severity: Major
Found in packages/explorer-2.0/components/WalletModal/index.tsx - About 30 mins to fix

Avoid too many return statements within this function.
Open

          return null;
Severity: Major
Found in packages/explorer-2.0/components/WalletModal/index.tsx - About 30 mins to fix

Avoid too many return statements within this function.
Open

      return (
        !isMobile &&
        !option.mobileOnly && (
          <Option
            onClick={() => {
Severity: Major
Found in packages/explorer-2.0/components/WalletModal/index.tsx - About 30 mins to fix

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  const close = () => {
    client.writeQuery({
      query: gql`
        query {
          walletModalOpen
Severity: Major
Found in packages/explorer-2.0/components/WalletModal/index.tsx and 3 other locations - About 40 mins to fix
packages/explorer-2.0/components/RoundStatus/index.tsx on lines 84..95
packages/explorer-2.0/components/StakingGuide/index.tsx on lines 40..51
packages/explorer-2.0/components/UniswapModal/index.tsx on lines 15..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status