livepeer/livepeerjs

View on GitHub
packages/subgraph/src/mappings/bondingManager.ts

Summary

Maintainability
F
3 days
Test Coverage

File bondingManager.ts has 531 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { store } from "@graphprotocol/graph-ts";

// Import event types from the registrar contract ABIs
import {
  BondingManager,
Severity: Major
Found in packages/subgraph/src/mappings/bondingManager.ts - About 1 day to fix

Function bond has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function bond(event: Bond): void {
  let bondingManager = BondingManager.bind(event.address);
  let delegateData = bondingManager.getDelegator(event.params.newDelegate);
  let delegatorData = bondingManager.getDelegator(event.params.delegator);
  let round = createOrLoadRound(event.block.number);
Severity: Major
Found in packages/subgraph/src/mappings/bondingManager.ts - About 2 hrs to fix

Function unbond has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function unbond(event: Unbond): void {
  let bondingManager = BondingManager.bind(event.address);
  let uniqueUnbondingLockId = makeUnbondingLockId(
    event.params.delegator,
    event.params.unbondingLockId
Severity: Major
Found in packages/subgraph/src/mappings/bondingManager.ts - About 2 hrs to fix

Function rebond has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function rebond(event: Rebond): void {
  let bondingManager = BondingManager.bind(event.address);
  let uniqueUnbondingLockId = makeUnbondingLockId(
    event.params.delegator,
    event.params.unbondingLockId
Severity: Major
Found in packages/subgraph/src/mappings/bondingManager.ts - About 2 hrs to fix

Function reward has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function reward(event: Reward): void {
  let transcoder = Transcoder.load(event.params.transcoder.toHex());
  let delegate = Delegator.load(event.params.transcoder.toHex());
  let round = createOrLoadRound(event.block.number);
  let poolId = makePoolId(event.params.transcoder.toHex(), round.id);
Severity: Minor
Found in packages/subgraph/src/mappings/bondingManager.ts - About 1 hr to fix

Function parameterUpdate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function parameterUpdate(event: ParameterUpdate): void {
  let bondingManager = BondingManager.bind(event.address);
  let protocol = createOrLoadProtocol();

  if (event.params.param == "unbondingPeriod") {
Severity: Minor
Found in packages/subgraph/src/mappings/bondingManager.ts - About 1 hr to fix

Function earningsClaimed has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function earningsClaimed(event: EarningsClaimed): void {
  let round = createOrLoadRound(event.block.number);
  let delegator = createOrLoadDelegator(event.params.delegator.toHex());
  delegator.lastClaimRound = event.params.endRound.toString();
  delegator.bondedAmount = delegator.bondedAmount.plus(
Severity: Minor
Found in packages/subgraph/src/mappings/bondingManager.ts - About 1 hr to fix

Function withdrawFees has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function withdrawFees(event: WithdrawFees): void {
  let bondingManager = BondingManager.bind(event.address);
  let delegator = Delegator.load(event.params.delegator.toHex());
  let delegatorData = bondingManager.getDelegator(event.params.delegator);
  let round = createOrLoadRound(event.block.number);
Severity: Minor
Found in packages/subgraph/src/mappings/bondingManager.ts - About 1 hr to fix

Function transcoderActivated has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function transcoderActivated(event: TranscoderActivated): void {
  let round = createOrLoadRound(event.block.number);
  let transcoder = createOrLoadTranscoder(event.params.transcoder.toHex());
  let protocol = Protocol.load("0");

Severity: Minor
Found in packages/subgraph/src/mappings/bondingManager.ts - About 1 hr to fix

Function transcoderDeactivated has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function transcoderDeactivated(event: TranscoderDeactivated): void {
  let transcoder = Transcoder.load(event.params.transcoder.toHex());
  let round = createOrLoadRound(event.block.number);
  let protocol = Protocol.load("0");

Severity: Minor
Found in packages/subgraph/src/mappings/bondingManager.ts - About 1 hr to fix

Function withdrawStake has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function withdrawStake(event: WithdrawStake): void {
  let round = createOrLoadRound(event.block.number);

  let uniqueUnbondingLockId = makeUnbondingLockId(
    event.params.delegator,
Severity: Minor
Found in packages/subgraph/src/mappings/bondingManager.ts - About 1 hr to fix

Function bond has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function bond(event: Bond): void {
  let bondingManager = BondingManager.bind(event.address);
  let delegateData = bondingManager.getDelegator(event.params.newDelegate);
  let delegatorData = bondingManager.getDelegator(event.params.delegator);
  let round = createOrLoadRound(event.block.number);
Severity: Minor
Found in packages/subgraph/src/mappings/bondingManager.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    event.params.oldDelegate.toHex() != EMPTY_ADDRESS.toHex() &&
    event.params.oldDelegate.toHex() != event.params.newDelegate.toHex()
Severity: Major
Found in packages/subgraph/src/mappings/bondingManager.ts and 1 other location - About 1 hr to fix
packages/subgraph/src/mappings/pollTallyHandlers.ts on lines 95..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status