livepeer/livepeerjs

View on GitHub
packages/subgraph/src/mappings/pollTallyHandlers.ts

Summary

Maintainability
D
2 days
Test Coverage

Function updatePollTallyOnBond has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

export function updatePollTallyOnBond(event: Bond): void {
  let pollAddress = dataSource.context().getString("poll");
  let poll = Poll.load(pollAddress) as Poll;

  // Return if poll is no longer active
Severity: Minor
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updatePollTallyOnBond has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function updatePollTallyOnBond(event: Bond): void {
  let pollAddress = dataSource.context().getString("poll");
  let poll = Poll.load(pollAddress) as Poll;

  // Return if poll is no longer active
Severity: Major
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts - About 3 hrs to fix

Function updatePollTally has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

function updatePollTally<T extends Rebond>(event: T): void {
  let pollAddress = dataSource.context().getString("poll");
  let poll = Poll.load(pollAddress) as Poll;
  let updateTally = false;

Severity: Minor
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updatePollTally has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function updatePollTally<T extends Rebond>(event: T): void {
  let pollAddress = dataSource.context().getString("poll");
  let poll = Poll.load(pollAddress) as Poll;
  let updateTally = false;

Severity: Major
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts - About 2 hrs to fix

File pollTallyHandlers.ts has 269 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  Address,
  BigDecimal,
  BigInt,
  dataSource,
Severity: Minor
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts - About 2 hrs to fix

Function updatePollTallyOnEarningsClaimed has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function updatePollTallyOnEarningsClaimed(event: EarningsClaimed): void {
  // After LIP-36 the pending stake of other delegators does not change
  // after earnings are claimed so after the LIP-36 mainnet upgrade block
  // we stop updating all voters vote weight on each EarningsClaimed event
  if (
Severity: Minor
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts - About 1 hr to fix

Function updatePollTallyOnReward has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function updatePollTallyOnReward(event: Reward): void {
  let voterAddress = dataSource.context().getString("voter");
  let delegator = Delegator.load(voterAddress) as Delegator;

  // Return if transcoder that called reward isn't voter's delegate
Severity: Minor
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts - About 1 hr to fix

Function updatePollTallyOnEarningsClaimed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function updatePollTallyOnEarningsClaimed(event: EarningsClaimed): void {
  // After LIP-36 the pending stake of other delegators does not change
  // after earnings are claimed so after the LIP-36 mainnet upgrade block
  // we stop updating all voters vote weight on each EarningsClaimed event
  if (
Severity: Minor
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updatePollTallyOnReward has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function updatePollTallyOnReward(event: Reward): void {
  let voterAddress = dataSource.context().getString("voter");
  let delegator = Delegator.load(voterAddress) as Delegator;

  // Return if transcoder that called reward isn't voter's delegate
Severity: Minor
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    event.params.oldDelegate.toHex() != EMPTY_ADDRESS.toHex() &&
    event.params.oldDelegate.toHex() != event.params.newDelegate.toHex();
Severity: Major
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts and 1 other location - About 1 hr to fix
packages/subgraph/src/mappings/bondingManager.ts on lines 72..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (delegate.status == "Registered") {
      delegateVote.registeredTranscoder = true;
      if (delegateVote.choiceID != null) {
        delegateVote.voteStake = delegate.totalStake as BigDecimal;
      }
Severity: Minor
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts and 1 other location - About 50 mins to fix
packages/subgraph/src/mappings/pollTallyHandlers.ts on lines 138..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (newDelegate.status == "Registered") {
      newDelegateVote.registeredTranscoder = true;
      if (newDelegateVote.choiceID != null) {
        newDelegateVote.voteStake = newDelegate.totalStake as BigDecimal;
      }
Severity: Minor
Found in packages/subgraph/src/mappings/pollTallyHandlers.ts and 1 other location - About 50 mins to fix
packages/subgraph/src/mappings/pollTallyHandlers.ts on lines 285..300

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status