livepeer/livepeerjs

View on GitHub
packages/subgraph/src/mappings/ticketBroker.ts

Summary

Maintainability
F
6 days
Test Coverage

Function winningTicketRedeemed has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function winningTicketRedeemed(event: WinningTicketRedeemed): void {
  let round = createOrLoadRound(event.block.number);
  let day = createOrLoadDay(event.block.timestamp.toI32());
  let winningTicketRedeemedEvent = new WinningTicketRedeemedEvent(
    makeEventId(event.transaction.hash, event.logIndex)
Severity: Major
Found in packages/subgraph/src/mappings/ticketBroker.ts - About 3 hrs to fix

Function reserveFunded has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function reserveFunded(event: ReserveFunded): void {
  let round = createOrLoadRound(event.block.number);
  let broadcaster = Broadcaster.load(event.params.reserveHolder.toHex());

  if (broadcaster == null) {
Severity: Minor
Found in packages/subgraph/src/mappings/ticketBroker.ts - About 1 hr to fix

Function depositFunded has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function depositFunded(event: DepositFunded): void {
  let round = createOrLoadRound(event.block.number);
  let broadcaster = Broadcaster.load(event.params.sender.toHex());

  if (broadcaster == null) {
Severity: Minor
Found in packages/subgraph/src/mappings/ticketBroker.ts - About 1 hr to fix

Function reserveClaimed has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function reserveClaimed(event: ReserveClaimed): void {
  let round = createOrLoadRound(event.block.number);
  let broadcaster = Broadcaster.load(event.params.reserveHolder.toHex());
  broadcaster.reserve = broadcaster.reserve.minus(
    convertToDecimal(event.params.amount)
Severity: Minor
Found in packages/subgraph/src/mappings/ticketBroker.ts - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function reserveFunded(event: ReserveFunded): void {
  let round = createOrLoadRound(event.block.number);
  let broadcaster = Broadcaster.load(event.params.reserveHolder.toHex());

  if (broadcaster == null) {
Severity: Major
Found in packages/subgraph/src/mappings/ticketBroker.ts and 1 other location - About 3 days to fix
packages/subgraph/src/mappings/ticketBroker.ts on lines 130..165

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 527.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function depositFunded(event: DepositFunded): void {
  let round = createOrLoadRound(event.block.number);
  let broadcaster = Broadcaster.load(event.params.sender.toHex());

  if (broadcaster == null) {
Severity: Major
Found in packages/subgraph/src/mappings/ticketBroker.ts and 1 other location - About 3 days to fix
packages/subgraph/src/mappings/ticketBroker.ts on lines 167..202

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 527.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status