Sign upLogin

lookitsatravis/api_guardian

View on GitHub
Star
lib/api_guardian/concerns/api_errors/handler.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method api_error_handler has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

          def api_error_handler(exception)
            ApiGuardian.logger.error 'ApiError: ' + exception.class.name + ' - ' + exception.message

            if exception.is_a? Pundit::NotAuthorizedError
              user_not_authorized
Severity: Minor
Found in lib/api_guardian/concerns/api_errors/handler.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method api_error_handler has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

          def api_error_handler(exception)
            ApiGuardian.logger.error 'ApiError: ' + exception.class.name + ' - ' + exception.message

            if exception.is_a? Pundit::NotAuthorizedError
              user_not_authorized
Severity: Major
Found in lib/api_guardian/concerns/api_errors/handler.rb - About 2 hrs to fix

    There are no issues that match your filters.

    Category
    Status