bus/net/message.go

Summary

Maintainability
B
4 hrs
Test Coverage
B
82%

Method Header.Read has 13 return statements (exceeds 4 allowed).
Open

func (h *Header) Read(r io.Reader) (err error) {
    if err = h.readMagic(r); err != nil {
        return fmt.Errorf("read message magic: %s", err)
    } else if h.Magic != Magic {
        return fmt.Errorf("invalid message magic: %x", h.Magic)
Severity: Major
Found in bus/net/message.go - About 1 hr to fix

    Method Header.Write has 11 return statements (exceeds 4 allowed).
    Open

    func (h *Header) Write(w io.Writer) (err error) {
        wrap := func(field string, err error) error {
            return fmt.Errorf("write message %s: %s", field, err)
        }
        if err = h.writeMagic(w); err != nil {
    Severity: Major
    Found in bus/net/message.go - About 1 hr to fix

      Method Message.Read has 7 return statements (exceeds 4 allowed).
      Open

      func (m *Message) Read(r io.Reader) error {
      
          // Read the complete header, then parse the fields.
          b := make([]byte, HeaderSize)
          if err := basic.ReadN(r, b, HeaderSize); err != nil {
      Severity: Major
      Found in bus/net/message.go - About 45 mins to fix

        Method Message.Write has 6 return statements (exceeds 4 allowed).
        Open

        func (m *Message) Write(w io.Writer) error {
        
            if uint32(len(m.Payload)) != m.Header.Size {
                return fmt.Errorf("invalid message size: %d instead of %d",
                    len(m.Payload), m.Header.Size)
        Severity: Major
        Found in bus/net/message.go - About 40 mins to fix

          Function NewHeader has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func NewHeader(typ uint8, service uint32, object uint32, action uint32, id uint32) Header {
          Severity: Minor
          Found in bus/net/message.go - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status