luin/express-di

View on GitHub

Showing 11 of 11 total issues

Function _dispatch has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

express.Router.prototype._dispatch = function(req, res, next){
  var params = this.params
    , self = this;


Severity: Minor
Found in lib/di.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _dispatch has 122 lines of code (exceeds 25 allowed). Consider refactoring.
Open

express.Router.prototype._dispatch = function(req, res, next){
  var params = this.params
    , self = this;


Severity: Major
Found in lib/di.js - About 4 hrs to fix

    Function pass has 118 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      (function pass(i, err){
        var paramCallbacks
          , paramIndex = 0
          , paramVal
          , route
    Severity: Major
    Found in lib/di.js - About 4 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                if (req.__di_caches[dependency]) {
                  callback(req.__di_caches[dependency][0], req.__di_caches[dependency][1]);
                } else {
                  factory(req, res, function(err, result) {
                    req.__di_caches[dependency] = [err, result];
      Severity: Major
      Found in lib/di.js and 1 other location - About 2 hrs to fix
      lib/di.js on lines 120..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (req.__di_caches[dependency]) {
                callback(req.__di_caches[dependency][0], req.__di_caches[dependency][1]);
              } else {
                factory(req, res, function(err, result) {
                  req.__di_caches[dependency] = [err, result];
      Severity: Major
      Found in lib/di.js and 1 other location - About 2 hrs to fix
      lib/di.js on lines 217..224

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function paramCallback has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function paramCallback(err) {
            var fn = paramCallbacks[paramIndex++];
            if (err || !fn) return param(err);
      
            var parameters = utils.getParameters(fn);
      Severity: Major
      Found in lib/di.js - About 2 hrs to fix

        Function route has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        express.Router.prototype.route = function(method, path) {
          var callbacks = utils.flatten([].slice.call(arguments, 2));
        
          callbacks = callbacks
            .map(function(fn) {
        Severity: Major
        Found in lib/di.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                    while(currentApp) {
                      factories = currentApp.get(diFactoriesKey);
                      if (factories) {
                        if (factories[dependency]) {
                          factory = factories[dependency];
          Severity: Major
          Found in lib/di.js and 1 other location - About 1 hr to fix
          lib/di.js on lines 104..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  while(currentApp) {
                    factories = currentApp.get(diFactoriesKey);
                    if (factories) {
                      if (factories[dependency]) {
                        factory = factories[dependency];
          Severity: Major
          Found in lib/di.js and 1 other location - About 1 hr to fix
          lib/di.js on lines 201..212

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function arraysEqual has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.arraysEqual = function(arr1, arr2) {
            if (arr1 === arr2) return true;
            if (arr1 === null || arr2 === null) return false;
            if (arr1.length != arr2.length) return false;
          
          
          Severity: Minor
          Found in lib/utils.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

            return true;
          Severity: Major
          Found in lib/utils.js - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language