lukemnet/blizzapi

View on GitHub

Showing 3 of 6 total issues

Function query has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const query = async (queryOptions: BattleNetQueryOptions) => {
  const { region, accessToken } = queryOptions;
  const {
    validateAccessTokenOnEachQuery,
    refreshExpiredAccessToken,
Severity: Minor
Found in src/helpers/bnet/query.ts - About 1 hr to fix

    Function fetchFromUri has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const fetchFromUri = async (options: FetchFromUriOptions) => {
      const {
        uri,
        timeout,
        headers,
    Severity: Minor
    Found in src/helpers/fetch/fetchFromUri.ts - About 1 hr to fix

      Function query has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      export const query = async (queryOptions: BattleNetQueryOptions) => {
        const { region, accessToken } = queryOptions;
        const {
          validateAccessTokenOnEachQuery,
          refreshExpiredAccessToken,
      Severity: Minor
      Found in src/helpers/bnet/query.ts - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language