luyadev/luya-module-admin

View on GitHub

Showing 331 of 503 total issues

Function generateClassName has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    protected function generateClassName($tableName, $useSchemaName = null)
    {
        if (isset($this->classNames[$tableName])) {
            return $this->classNames[$tableName];
        }
Severity: Minor
Found in src/base/BaseCrudController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function actionIndex has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function actionIndex()
    {
        $tempName = null;
        if ($this->identifier === null) {
            $this->identifier = Inflector::variablize($this->prompt('Enter the filter identifier: (e.g. profilePicture)', ['required' => true, 'pattern' => '/^[a-zA-Z0-9]+$/i', 'error' => 'The filter identifer can only contain a-z,A-Z,0-9']));
Severity: Minor
Found in src/commands/FilterController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function controller has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        controller: ['$scope', function ($scope) {
            if ($scope.model === undefined) {
                $scope.model = [];
            }

Severity: Minor
Found in src/resources/js/formdirectives.js - About 1 hr to fix

    Function controller has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            controller: ['$scope', function ($scope) {
    
                if ($scope.model === undefined || !$scope.model) {
                    if ($scope.initvalue) {
                        $scope.model = $scope.initvalue
    Severity: Minor
    Found in src/resources/js/formdirectives.js - About 1 hr to fix

      Function template has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              template: function () {
                  return '' +
                      '<div class="form-group form-side-by-side" ng-class="{\'input--hide-label\': i18n}">' +
                      '<div class="form-side form-side-label">' +
                      '<label ng-if="label">{{label}}</label>' +
      Severity: Minor
      Found in src/resources/js/formdirectives.js - About 1 hr to fix

        Method run has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run()
            {
                $this->refresh('thumbnail', [
                    'name' => 'Thumbnail',
                    'imagine_name' => 'thumbnail',
        Severity: Minor
        Found in src/importers/FilterImporter.php - About 1 hr to fix

          Method parseDocBlockToArrays has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function parseDocBlockToArrays(PhpDocReflection $reflection)
              {
                  $rows = [
                      'texts' => [],
                      'return' => [], // @return <type> <description>
          Severity: Minor
          Found in src/openapi/phpdoc/PhpDocParser.php - About 1 hr to fix

            Function template has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    template: function () {
                        return '' +
                            '<div class="form-group form-side-by-side" ng-class="{\'input--hide-label\': i18n}">' +
                            '<div class="form-side form-side-label">' +
                            '<label for="{{id}}">{{label}}</label>' +
            Severity: Minor
            Found in src/resources/js/formdirectives.js - About 1 hr to fix

              Method actionUser has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function actionUser()
                  {
                      while (true) {
                          $email = $this->prompt('User Email:');
                          if (!empty(User::findByEmail($email))) {
              Severity: Minor
              Found in src/commands/SetupController.php - About 1 hr to fix

                Method safeUp has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function safeUp()
                    {
                        // user login agent
                        $this->addColumn('{{%admin_user_login}}', 'user_agent', $this->string());
                
                
                Severity: Minor
                Found in src/migrations/m200128_141129_v3_update.php - About 1 hr to fix

                  Method actionTwofaToken has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function actionTwofaToken()
                      {
                          if (($lockout = $this->sessionBruteForceLock(Yii::$app->session->get('secureId')))) {
                              return $this->sendArray(false, [Module::t('login_async_submission_limit_reached', ['time' =>  Yii::$app->formatter->asRelativeTime($lockout)])]);
                          }
                  Severity: Minor
                  Found in src/controllers/LoginController.php - About 1 hr to fix

                    Method actionReset has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function actionReset()
                        {
                            if (!$this->module->resetPassword) {
                                throw new ForbiddenHttpException();
                            }
                    Severity: Minor
                    Found in src/controllers/LoginController.php - About 1 hr to fix

                      Function onAfterListFind has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function onAfterListFind($event)
                          {
                              $value = $event->sender->getAttribute($this->name);
                              if (!$this->i18n) {
                                  $value = $this->jsonDecode($value);
                      Severity: Minor
                      Found in src/ngrest/plugins/CheckboxList.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function onBeforeSave has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function onBeforeSave($event)
                          {
                              // if its not i18n casted field we have to serialize the file array as json and abort further event excution.
                              if (!$this->i18n) {
                                  // as it could be an assigned array from the frontend model assigne via a form, we verify if the array contains a value key.
                      Severity: Minor
                      Found in src/ngrest/plugins/CheckboxList.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function run($id)
                          {
                              $model = $this->modelClass::ngRestFind()->byPrimaryKey($id)->one();
                      
                              if (!$model) {
                      Severity: Minor
                      Found in src/ngrest/base/actions/DeleteAction.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function observeLogin has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                      var observeLogin = function (form, url, secureUrl, twoFaUrl) {
                      
                          $(form).submit(function (e) {
                              $('#errorsContainer').hide();
                              $('.login-btn[type="submit"]').attr('disabled', true);
                      Severity: Minor
                      Found in src/resources/js/login.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function ensureFileUpload has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function ensureFileUpload($fileSource, $fileName)
                          {
                              // throw exception if source or name is empty
                              if (empty($fileSource) || empty($fileName)) {
                                  throw new Exception("Filename and source can not be empty.");
                      Severity: Minor
                      Found in src/storage/BaseFileSystemStorage.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function createImage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function createImage($fileId, $filterId)
                          {
                              gc_collect_cycles();
                      
                              $image = StorageImage::find()->where(['file_id' => $fileId, 'filter_id' => $filterId])->one();
                      Severity: Minor
                      Found in src/storage/BaseFileSystemStorage.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function actionCleanupImageTable has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function actionCleanupImageTable()
                          {
                              $rows = Yii::$app->db->createCommand('SELECT file_id, filter_id, COUNT(*) as count FROM {{%admin_storage_image}} GROUP BY file_id, filter_id HAVING COUNT(*) > 1')->queryAll();
                      
                              if (empty($rows)) {
                      Severity: Minor
                      Found in src/commands/StorageController.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function startImages has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function startImages()
                          {
                              $imageCount = 0;
                              // sync images
                              foreach ((new \luya\admin\image\Query())->all() as $image) {
                      Severity: Minor
                      Found in src/proxy/ClientTransfer.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language