luyadev/luya

View on GitHub

Showing 133 of 133 total issues

Function getExceptionArray has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function getExceptionArray($exception)
    {
        $_message = 'Uknonwn exception object, not instance of \Exception.';
        $_file = 'unknown';
        $_line = 0;
Severity: Minor
Found in core/traits/ErrorHandlerTrait.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function actionCreate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function actionCreate()
    {
        Console::clearScreenBeforeCursor();
        
        $moduleName = $this->prompt("Enter the name of the module you like to generate:");
Severity: Minor
Found in core/console/commands/ModuleController.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function init()
    {
        $path = Yii::getAlias($this->configFile);
        if (file_exists($path)) {
            $config = (include($path));
Severity: Minor
Found in core/web/Element.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function actionAdd has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function actionAdd($repo, $filename, $language = "*")
    {
        $repoPath = "repos/$repo";
        $messageFiles = glob("$repoPath/src/**/messages/$language/$filename.php") ?: glob("$repoPath/src/messages/$language/$filename.php");

Severity: Minor
Found in dev/TranslationController.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return 'n_date';
Severity: Major
Found in core/helpers/XLSXWriter.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return 'n_numeric';
    Severity: Major
    Found in core/helpers/XLSXWriter.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $this->outputSuccess("Theme files has been created successfully. Please run `".$_SERVER['PHP_SELF']." import` to import the theme into the database.");
      Severity: Major
      Found in core/console/commands/ThemeController.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return 0;
        Severity: Major
        Found in core/helpers/XLSXWriter.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return 0;
          Severity: Major
          Found in core/helpers/XLSXWriter.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return 'n_numeric';
            Severity: Major
            Found in core/helpers/XLSXWriter.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return 'n_date';
              Severity: Major
              Found in core/helpers/XLSXWriter.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return $days + $seconds;
                Severity: Major
                Found in core/helpers/XLSXWriter.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return $model->addError($attribute, Yii::t('luya', '{attribute} must include at least one lowercase letter.', ['attribute' => $model->getAttributeLabel($attribute)]));
                  Severity: Major
                  Found in core/validators/StrengthValidator.php - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    $(document).trigger("lazyimage-loaded", {
                                        type: 'success',
                                        imageId: '.' + settings.imageIdentifierPrefix + image.id
                                    });
                    Severity: Minor
                    Found in core/resources/lazyload/lazyload.src.js and 1 other location - About 30 mins to fix
                    core/resources/lazyload/lazyload.src.js on lines 215..218

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid too many return statements within this method.
                    Open

                            return 'n_auto';
                    Severity: Major
                    Found in core/helpers/XLSXWriter.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return 'n_date';
                      Severity: Major
                      Found in core/helpers/XLSXWriter.php - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        $(document).trigger("lazyimage-loaded", {
                                            type: 'error',
                                            imageId: '.' + settings.imageIdentifierPrefix + image.id
                                        });
                        Severity: Minor
                        Found in core/resources/lazyload/lazyload.src.js and 1 other location - About 30 mins to fix
                        core/resources/lazyload/lazyload.src.js on lines 204..207

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Avoid too many return statements within this method.
                        Open

                                    return 'n_numeric';
                        Severity: Major
                        Found in core/helpers/XLSXWriter.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return $model->addError($attribute, Yii::t('luya', '{attribute} must include at least one uppercase letter.', ['attribute' => $model->getAttributeLabel($attribute)]));
                          Severity: Major
                          Found in core/validators/StrengthValidator.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return 'n_datetime';
                            Severity: Major
                            Found in core/helpers/XLSXWriter.php - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language