maestro-server/data-app

View on GitHub

Showing 111 of 111 total issues

Similar blocks of code found in 20 locations. Consider refactoring.
Open

Severity: Major
Found in app/controller/dcProjects.py and 19 other locations - About 35 mins to fix
app/controller/dcAdminer.py on lines 0..120
app/controller/dcApplications.py on lines 0..124
app/controller/dcClients.py on lines 0..124
app/controller/dcConnections.py on lines 0..124
app/controller/dcDatacenter.py on lines 0..124
app/controller/dcEvents.py on lines 0..124
app/controller/dcFlavors.py on lines 0..124
app/controller/dcFlavorsPublic.py on lines 0..118
app/controller/dcGraphs.py on lines 0..124
app/controller/dcImages.py on lines 0..124
app/controller/dcNetwork.py on lines 0..124
app/controller/dcReports.py on lines 0..124
app/controller/dcSchedulers.py on lines 0..124
app/controller/dcServers.py on lines 0..124
app/controller/dcServices.py on lines 0..124
app/controller/dcSnapshots.py on lines 0..124
app/controller/dcSystem.py on lines 0..124
app/controller/dcTeams.py on lines 0..124
app/controller/dcVolumes.py on lines 0..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

Severity: Major
Found in app/controller/dcSystem.py and 19 other locations - About 35 mins to fix
app/controller/dcAdminer.py on lines 0..120
app/controller/dcApplications.py on lines 0..124
app/controller/dcClients.py on lines 0..124
app/controller/dcConnections.py on lines 0..124
app/controller/dcDatacenter.py on lines 0..124
app/controller/dcEvents.py on lines 0..124
app/controller/dcFlavors.py on lines 0..124
app/controller/dcFlavorsPublic.py on lines 0..118
app/controller/dcGraphs.py on lines 0..124
app/controller/dcImages.py on lines 0..124
app/controller/dcNetwork.py on lines 0..124
app/controller/dcProjects.py on lines 0..124
app/controller/dcReports.py on lines 0..124
app/controller/dcSchedulers.py on lines 0..124
app/controller/dcServers.py on lines 0..124
app/controller/dcServices.py on lines 0..124
app/controller/dcSnapshots.py on lines 0..124
app/controller/dcTeams.py on lines 0..124
app/controller/dcVolumes.py on lines 0..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function makeFilter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def makeFilter(self, item):
        opts = ['_id', 'unique_id']
        filter = {}

        for opt in opts:
Severity: Minor
Found in app/controller/factory/dc.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line too long (115 > 79 characters)
Open

    @apiParam {Array} body List of batches data, if exist _id this item only be updated, otherwise will be created.
Severity: Minor
Found in app/controller/dcConnections.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (83 > 79 characters)
Open

                                                 {'msg': 'Query params is needed'},
Severity: Minor
Found in app/controller/factory/dc.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (103 > 79 characters)
Open

    @apiParam (Body x-www) {Json} query Aggregation query (See, mongodb aggregate for more information)
Severity: Minor
Found in app/controller/aggregationApp.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (133 > 79 characters)
Open

    @apiDescription Look like te same of get action, if you need to do a long filters likes a list of ids, you can use this endpoint.
Severity: Minor
Found in app/controller/dcGraphs.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (115 > 79 characters)
Open

    @apiParam {Array} body List of batches data, if exist _id this item only be updated, otherwise will be created.
Severity: Minor
Found in app/controller/dcReports.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (115 > 79 characters)
Open

    @apiParam {Array} body List of batches data, if exist _id this item only be updated, otherwise will be created.
Severity: Minor
Found in app/controller/dcSnapshots.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (115 > 79 characters)
Open

    @apiParam {Array} body List of batches data, if exist _id this item only be updated, otherwise will be created.
Severity: Minor
Found in app/controller/dcVolumes.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Trailing whitespace
Open

    @staticmethod   
Severity: Minor
Found in app/services/ruler.py by pep8

Trailing whitespace is superfluous.

The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

Line too long (83 > 79 characters)
Open

        result = self.col.update_one(Model.makeObjectId(self.__id), setUpdatedData)
Severity: Minor
Found in app/repository/model.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Blank line contains whitespace
Open

            
Severity: Minor
Found in app/repository/model.py by pep8

Trailing whitespace is superfluous.

The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

Line too long (115 > 79 characters)
Open

    @apiParam {Array} body List of batches data, if exist _id this item only be updated, otherwise will be created.
Severity: Minor
Found in app/controller/dcEvents.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (115 > 79 characters)
Open

    @apiParam {Array} body List of batches data, if exist _id this item only be updated, otherwise will be created.
Severity: Minor
Found in app/controller/dcGraphs.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (133 > 79 characters)
Open

    @apiDescription Look like te same of get action, if you need to do a long filters likes a list of ids, you can use this endpoint.
Severity: Minor
Found in app/controller/dcReports.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

No newline at end of file
Open

    return wrapper

Trailing blank lines are superfluous.

Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

Expected 2 blank lines, found 1
Open

class Config(object):

Separate top-level function and class definitions with two blank lines.

Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

Blank line contains whitespace
Open

    
Severity: Minor
Found in app/controller/connection.py by pep8

Trailing whitespace is superfluous.

The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

Line too long (133 > 79 characters)
Open

    @apiDescription Look like te same of get action, if you need to do a long filters likes a list of ids, you can use this endpoint.
Severity: Minor
Found in app/controller/dcFlavors.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.
Severity
Category
Status
Source
Language