maestro-server/discovery-api

View on GitHub
app/repository/providers/azure/hooks.py

Summary

Maintainability
A
1 hr
Test Coverage
F
25%

Function cpuAndMemoryByInstanceType has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def cpuAndMemoryByInstanceType(obj, conn):
        instance = get(obj, 'datacenters.instance')

        if instance:
            data = CacheMemory.get(instance)
Severity: Minor
Found in app/repository/providers/azure/hooks.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ipv4 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def ipv4(obj, conn, len):
        Crawler = HookedAzure.createConn(conn)
        options = {
            "access": "network_interfaces",
            "command": "network",
Severity: Minor
Found in app/repository/providers/azure/hooks.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Comparison to none should be 'if cond is none:'
Open

        if HookedAzure._conn == None:

Comparison to singletons should use "is" or "is not".

Comparisons to singletons like None should always be done
with "is" or "is not", never the equality operators.

Okay: if arg is not None:
E711: if arg != None:
E711: if None == arg:
E712: if arg == True:
E712: if False == arg:

Also, beware of writing if x when you really mean if x is not None
-- e.g. when testing whether a variable or argument that defaults to
None was set to some other value.  The other value might have a type
(such as a container) that could be false in a boolean context!

Line too long (81 > 79 characters)
Open

                    .post_request(path="flavors_public", body={'query': query}) \

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status