Sign upLogin

maestro-server/discovery-api

View on GitHub
Star
app/services/rules/ruler.py

Summary

Maintainability
A
50 mins
Test Coverage
F
34%

Function switch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def switch(source, batch, default=None, capitalize=False):
        fields = source.split('|')
        for field in fields:
            result = get(batch, field)
            if result:
Severity: Minor
Found in app/services/rules/ruler.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function arrCatcher has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def arrCatcher(source, batch, cap=True):
        list = get(batch, source['field'], [])
        for item in list:
            if item[source['sKey']].lower() == source['s'].lower():
                tmp = item[source['catcher']]
Severity: Minor
Found in app/services/rules/ruler.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line too long (85 > 79 characters)
Open

        return IteratorRuler().batch(items=items, Ruler=Ruler, source=batch).result()
Severity: Minor
Found in app/services/rules/ruler.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status