mambax7/marquee

View on GitHub
include/onupdate.php

Summary

Maintainability
C
1 day
Test Coverage

Function xoops_module_update_marquee has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

function xoops_module_update_marquee(\XoopsModule $module, $previousVersion = null)
{
    $moduleDirName      = \basename(\dirname(__DIR__));
    $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
    /** @var Marquee\Helper $helper */ /** @var Marquee\Utility $utility */
Severity: Minor
Found in include/onupdate.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method xoops_module_update_marquee has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function xoops_module_update_marquee(\XoopsModule $module, $previousVersion = null)
{
    $moduleDirName      = \basename(\dirname(__DIR__));
    $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
    /** @var Marquee\Helper $helper */ /** @var Marquee\Utility $utility */
Severity: Major
Found in include/onupdate.php - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                if (\is_file($templateFolder . $v)) {
                                    unlink($templateFolder . $v);
                                }
    Severity: Major
    Found in include/onupdate.php - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status