mambax7/moduleinstaller

View on GitHub
class/InstallWizard.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function createForm has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function createForm()
    {
        $hidden = '';
        $ret    = '';

Severity: Minor
Found in class/InstallWizard.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkAccess has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function checkAccess()
    {
        if (INSTALL_USER != '' && INSTALL_PASSWORD != '') {
            if (!isset($_SERVER['PHP_AUTH_USER'])) {
                \header('WWW-Authenticate: Basic realm="XOOPS Installer"');
Severity: Minor
Found in class/InstallWizard.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkAccess has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function checkAccess()
    {
        if (INSTALL_USER != '' && INSTALL_PASSWORD != '') {
            if (!isset($_SERVER['PHP_AUTH_USER'])) {
                \header('WWW-Authenticate: Basic realm="XOOPS Installer"');
Severity: Minor
Found in class/InstallWizard.php - About 1 hr to fix

    Function pageURI has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function pageURI($page)
        {
            $pages     = \array_keys($this->pages);
            $pageIndex = $this->pageIndex;
            if (!(int)$page[0]) {
    Severity: Minor
    Found in class/InstallWizard.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return false;
    Severity: Major
    Found in class/InstallWizard.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in class/InstallWizard.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status