mambax7/pedigree

View on GitHub
admin/blocksadmin.php

Summary

Maintainability
F
4 days
Test Coverage

Method listBlocks has 213 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function listBlocks()
    {
        global $xoopsModule, $pathIcon16;
        require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
        $moduleDirName      = basename(\dirname(__DIR__));
Severity: Major
Found in admin/blocksadmin.php - About 1 day to fix

    File blocksadmin.php has 474 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * You may not change or alter any portion of this comment or credits
     * of supporting developers from this source code or any supporting source code
     * which is considered copyrighted (c) material of the original comment or credit authors.
    Severity: Minor
    Found in admin/blocksadmin.php - About 7 hrs to fix

      Function listBlocks has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
      Open

          function listBlocks()
          {
              global $xoopsModule, $pathIcon16;
              require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
              $moduleDirName      = basename(\dirname(__DIR__));
      Severity: Minor
      Found in admin/blocksadmin.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isBlockCloned has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          function isBlockCloned($bid, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options)
          {
              xoops_loadLanguage('admin', 'system');
              xoops_loadLanguage('admin/blocksadmin', 'system');
              xoops_loadLanguage('admin/groups', 'system');
      Severity: Minor
      Found in admin/blocksadmin.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method isBlockCloned has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function isBlockCloned($bid, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options)
          {
              xoops_loadLanguage('admin', 'system');
              xoops_loadLanguage('admin/blocksadmin', 'system');
              xoops_loadLanguage('admin/groups', 'system');
      Severity: Major
      Found in admin/blocksadmin.php - About 2 hrs to fix

        Function updateBlock has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            function updateBlock($bid, $btitle, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options, $groups)
            {
                $myblock = new \XoopsBlock($bid);
                $myblock->setVar('title', $btitle);
                $myblock->setVar('weight', $bweight);
        Severity: Minor
        Found in admin/blocksadmin.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method cloneBlock has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function cloneBlock($bid)
            {
                require_once __DIR__ . '/admin_header.php';
                //require_once __DIR__ . '/admin_header.php';
                xoops_cp_header();
        Severity: Minor
        Found in admin/blocksadmin.php - About 1 hr to fix

          Method editBlock has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function editBlock($bid)
              {
                  require_once __DIR__ . '/admin_header.php';
                  //require_once __DIR__ . '/admin_header.php';
                  xoops_cp_header();
          Severity: Minor
          Found in admin/blocksadmin.php - About 1 hr to fix

            Method updateBlock has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function updateBlock($bid, $btitle, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options, $groups)
                {
                    $myblock = new \XoopsBlock($bid);
                    $myblock->setVar('title', $btitle);
                    $myblock->setVar('weight', $bweight);
            Severity: Minor
            Found in admin/blocksadmin.php - About 1 hr to fix

              Method updateBlock has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  function updateBlock($bid, $btitle, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options, $groups)
              Severity: Major
              Found in admin/blocksadmin.php - About 1 hr to fix

                Method isBlockCloned has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    function isBlockCloned($bid, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options)
                Severity: Major
                Found in admin/blocksadmin.php - About 50 mins to fix

                  Method setOrder has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      function setOrder($bid, $title, $weight, $visible, $side, $bcachetime)
                  Severity: Minor
                  Found in admin/blocksadmin.php - About 45 mins to fix

                    There are no issues that match your filters.

                    Category
                    Status