mambax7/pedigree

View on GitHub
admin/tools.php

Summary

Maintainability
D
1 day
Test Coverage

File tools.php has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
Severity: Minor
Found in admin/tools.php - About 5 hrs to fix

    Method settings has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function settings()
    {
        global $xoopsTpl;
        $helper = Helper::getInstance();
        require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
    Severity: Major
    Found in admin/tools.php - About 2 hrs to fix

      Method lang has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function lang()
      {
          global $xoopsTpl;
          $helper = Helper::getInstance();
          require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
      Severity: Minor
      Found in admin/tools.php - About 1 hr to fix

        Method database_oa has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function database_oa()
        {
            global $xoopsTpl;
            $form   = _AM_PEDIGREE_DATABASE_CHECK_ANCESTORS;
            $sql    = 'SELECT d.id AS d_id, d.pname AS d_pname
        Severity: Minor
        Found in admin/tools.php - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              $sql    = 'SELECT d.id AS d_id, d.pname AS d_pname
                      FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_registry') . ' d
                      LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_registry') . ' m ON m.id = d.mother
                      LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_registry') . ' f ON f.id = d.father
                      LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_registry') . ' mm ON mm.id = m.mother
          Severity: Major
          Found in admin/tools.php and 1 other location - About 2 hrs to fix
          tools.php on lines 446..469

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 133.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

              foreach ($_POST as $key => $values) {
                  if (in_array($key, $settings)) {
                      //          $query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('config') . " SET conf_value = '" . $values . "' WHERE conf_name = '" . $key . "'";
                      $query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('config') . " SET conf_value = '" . $GLOBALS['xoopsDB']->escape($values) . "' WHERE conf_name = '" . $GLOBALS['xoopsDB']->escape($key) . "'";
                      $GLOBALS['xoopsDB']->query($query);
          Severity: Major
          Found in admin/tools.php and 2 other locations - About 50 mins to fix
          admin/tools.php on lines 485..491
          tools.php on lines 296..302

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 97.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

              foreach ($_POST as $key => $values) {
                  if (in_array($key, $settings)) {
                      //          $query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('config') . " SET conf_value = '" . $values . "' WHERE conf_name = '" . $key . "'";
                      $query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('config') . " SET conf_value = '" . $GLOBALS['xoopsDB']->escape($values) . "' WHERE conf_name = '" . $GLOBALS['xoopsDB']->escape($key) . "'";
                      $GLOBALS['xoopsDB']->query($query);
          Severity: Major
          Found in admin/tools.php and 2 other locations - About 50 mins to fix
          admin/tools.php on lines 402..408
          tools.php on lines 296..302

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 97.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status