mambax7/publisher

View on GitHub
admin/import/smartsection.php

Summary

Maintainability
B
4 hrs
Test Coverage

Avoid deeply nested control flow statements.
Open

                if (file_exists($filename)) {
                    if (copy($filename, $GLOBALS['xoops']->path('uploads/publisher/' . $arrFile['filename']))) {
                        /** @var File $fileObj */
                        $fileObj = $helper->getHandler('File')->create();
                        $fileObj->setVars($arrFile);
Severity: Major
Found in admin/import/smartsection.php - About 45 mins to fix

    TODO found
    Open

                // TODO: move article images to image manager
    Severity: Minor
    Found in admin/import/smartsection.php by fixme

    TODO found
    Open

                // TODO: copy contents folder
    Severity: Minor
    Found in admin/import/smartsection.php by fixme

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        foreach ($comments as $comment) {
            $comment->setVar('com_itemid', $newArticleArray[$comment->getVar('com_itemid')]);
            $comment->setVar('com_modid', $publisher_module_id);
            $comment->setNew();
            if ($commentHandler->insert($comment)) {
    Severity: Major
    Found in admin/import/smartsection.php and 7 other locations - About 1 hr to fix
    admin/import/ams.php on lines 433..442
    admin/import/cjaycontent.php on lines 174..183
    admin/import/fmcontent.php on lines 352..361
    admin/import/news.php on lines 272..281
    admin/import/wfsection.php on lines 268..277
    admin/import/xfsection.php on lines 266..275
    admin/import/xnews.php on lines 434..443

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

        foreach ($newCatArray as $oldid => $newCat) {
            $criteria = new \CriteriaCompo();
            $criteria->add(new \Criteria('categoryid', $newCat['newid']));
            $oldpid = $newCat['oldpid'];
            if (0 == $oldpid) {
    Severity: Major
    Found in admin/import/smartsection.php and 5 other locations - About 1 hr to fix
    admin/import/ams.php on lines 408..419
    admin/import/news.php on lines 248..259
    admin/import/wfsection.php on lines 243..254
    admin/import/xfsection.php on lines 241..252
    admin/import/xnews.php on lines 409..420

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There must be one USE keyword per declaration
    Open

    use XoopsModules\Publisher\{

    There are no issues that match your filters.

    Category
    Status