mambax7/publisher

File xnews.php has 279 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php declare(strict_types=1);
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

Avoid deeply nested control flow statements.

Open

                if (file_exists($filename)) {
                    if (copy($filename, $GLOBALS['xoops']->path('uploads/publisher/' . $arrFile['filerealname']))) {
                        /** @var File $fileObj */
                        $fileObj = $helper->getHandler('File')
                                          ->create();

Similar blocks of code found in 2 locations. Consider refactoring.

Open

if ('start' === $op) {
    xoops_load('XoopsFormLoader');

    Utility::cpHeader();
    //publisher_adminMenu(-1, _AM_PUBLISHER_IMPORT);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            while (false !== ($arrFile = $GLOBALS['xoopsDB']->fetchArray($resultFiles))) {
                $filename = $GLOBALS['xoops']->path('uploads/xnews/attached/' . $arrFile['downloadname']);
                if (file_exists($filename)) {
                    if (copy($filename, $GLOBALS['xoops']->path('uploads/publisher/' . $arrFile['filerealname']))) {
                        /** @var File $fileObj */

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

    foreach ($comments as $comment) {
        $comment->setVar('com_itemid', $newArticleArray[(int)$comment->getVar('com_itemid')]);
        $comment->setVar('com_modid', $publisher_module_id);
        $comment->setNew();
        if ($commentHandler->insert($comment)) {

• Read up
  Read up

Identical blocks of code found in 6 locations. Consider refactoring.

Open

    foreach ($newCatArray as $oldid => $newCat) {
        $criteria = new \CriteriaCompo();
        $criteria->add(new \Criteria('categoryid', $newCat['newid']));
        $oldpid = $newCat['oldpid'];
        if (0 == $oldpid) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (('blank.gif' !== $arrCat['topic_imgurl']) && ('' !== $arrCat['topic_imgurl'])) {
            if (copy($GLOBALS['xoops']->path('uploads/xnews/topics/' . $arrCat['topic_imgurl']), $GLOBALS['xoops']->path('uploads/' . PUBLISHER_DIRNAME . '/images/category/' . $arrCat['topic_imgurl']))) {
                $categoryObj->setVar('image', $arrCat['topic_imgurl']);

                //======== there is no need to add the category images to Image Manager, because they are handled directly from /images/category/ folder

• Read up
  Read up

Only one argument is allowed per line in a multi-line function call

Open

                ), 'categoryid', 'parentid'

• Exclude checks
  • Disable engine
  • Disable check

Only one argument is allowed per line in a multi-line function call

Open

                ), 'categoryid', 'parentid'

• Exclude checks
  • Disable engine
  • Disable check