mambax7/publisher

View on GitHub
admin/import/xnews.php

Summary

Maintainability
F
1 wk
Test Coverage

File xnews.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);
/*
 You may not change or alter any portion of this comment or credits
Severity: Minor
Found in admin/import/xnews.php - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                    if (file_exists($filename)) {
                        if (copy($filename, $GLOBALS['xoops']->path('uploads/publisher/' . $arrFile['filerealname']))) {
                            /** @var File $fileObj */
                            $fileObj = $helper->getHandler('File')->create();
                            $fileObj->setVar('name', $arrFile['filerealname']);
    Severity: Major
    Found in admin/import/xnews.php - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      if ('start' === $op) {
          xoops_load('XoopsFormLoader');
      
          Utility::cpHeader();
          //publisher_adminMenu(-1, _AM_PUBLISHER_IMPORT);
      Severity: Major
      Found in admin/import/xnews.php and 1 other location - About 6 days to fix
      admin/import/ams.php on lines 45..169

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 1193.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  while (false !== ($arrFile = $GLOBALS['xoopsDB']->fetchArray($resultFiles))) {
                      $filename = $GLOBALS['xoops']->path('uploads/xnews/attached/' . $arrFile['downloadname']);
                      if (file_exists($filename)) {
                          if (copy($filename, $GLOBALS['xoops']->path('uploads/publisher/' . $arrFile['filerealname']))) {
                              /** @var File $fileObj */
      Severity: Major
      Found in admin/import/xnews.php and 1 other location - About 1 day to fix
      admin/import/ams.php on lines 362..384

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 320.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          foreach ($comments as $comment) {
              $comment->setVar('com_itemid', $newArticleArray[$comment->getVar('com_itemid')]);
              $comment->setVar('com_modid', $publisher_module_id);
              $comment->setNew();
              if ($commentHandler->insert($comment)) {
      Severity: Major
      Found in admin/import/xnews.php and 7 other locations - About 1 hr to fix
      admin/import/ams.php on lines 433..442
      admin/import/cjaycontent.php on lines 174..183
      admin/import/fmcontent.php on lines 352..361
      admin/import/news.php on lines 272..281
      admin/import/smartsection.php on lines 250..259
      admin/import/wfsection.php on lines 268..277
      admin/import/xfsection.php on lines 266..275

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 120.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 6 locations. Consider refactoring.
      Open

          foreach ($newCatArray as $oldid => $newCat) {
              $criteria = new \CriteriaCompo();
              $criteria->add(new \Criteria('categoryid', $newCat['newid']));
              $oldpid = $newCat['oldpid'];
              if (0 == $oldpid) {
      Severity: Major
      Found in admin/import/xnews.php and 5 other locations - About 1 hr to fix
      admin/import/ams.php on lines 408..419
      admin/import/news.php on lines 248..259
      admin/import/smartsection.php on lines 226..237
      admin/import/wfsection.php on lines 243..254
      admin/import/xfsection.php on lines 241..252

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 111.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (('blank.gif' !== $arrCat['topic_imgurl']) && ('' !== $arrCat['topic_imgurl'])) {
                  if (copy($GLOBALS['xoops']->path('uploads/xnews/topics/' . $arrCat['topic_imgurl']), $GLOBALS['xoops']->path('uploads/' . PUBLISHER_DIRNAME . '/images/category/' . $arrCat['topic_imgurl']))) {
                      $categoryObj->setVar('image', $arrCat['topic_imgurl']);
      
                      //======== there is no need to add the category images to Image Manager, because they are handled directly from /images/category/ folder
      Severity: Major
      Found in admin/import/xnews.php and 1 other location - About 1 hr to fix
      admin/import/ams.php on lines 238..263

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There must be one USE keyword per declaration
      Open

      use XoopsModules\Publisher\{
      Severity: Minor
      Found in admin/import/xnews.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status