mambax7/publisher

View on GitHub
assets/js/ajaxupload.3.9.js

Summary

Maintainability
D
1 day
Test Coverage

File ajaxupload.3.9.js has 368 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * AJAX Upload ( http://valums.com/ajax-upload/ )
 * Copyright (c) Andris Valums
 * Licensed under the MIT license ( http://valums.com/mit-license/ )
 * Thanks to Gary Haran, David Mark, Corey Burns and others for contributions
Severity: Minor
Found in assets/js/ajaxupload.3.9.js - About 4 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        if (document.documentElement.getBoundingClientRect) {
            // Get Offset using getBoundingClientRect
            // http://ejohn.org/blog/getboundingclientrect-is-awesome/
            var getOffset = function (el) {
                var box = el.getBoundingClientRect();
    Severity: Critical
    Found in assets/js/ajaxupload.3.9.js - About 3 hrs to fix

      Function _createInput has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _createInput: function () {
                  var self = this;
      
                  var input = document.createElement("input");
                  input.setAttribute('type', 'file');
      Severity: Major
      Found in assets/js/ajaxupload.3.9.js - About 2 hrs to fix

        Function AjaxUpload has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            window.AjaxUpload = function (button, options) {
                this._settings = {
                    // Location of the server-side upload script
                    action: 'upload.php',
                    // File upload name
        Severity: Minor
        Found in assets/js/ajaxupload.3.9.js - About 1 hr to fix

          Function _getResponse has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  _getResponse: function (iframe, file) {
                      // getting response
                      var toDeleteFlag = false, self = this, settings = this._settings;
          
                      addEvent(iframe, 'load', function () {
          Severity: Minor
          Found in assets/js/ajaxupload.3.9.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        var top = box.top / zoom + (window.pageYOffset || docElem && docElem.scrollTop / zoom || body.scrollTop / zoom) - clientTop, left = box.left / zoom + (window.pageXOffset || docElem && docElem.scrollLeft / zoom || body.scrollLeft / zoom) - clientLeft;
            Severity: Minor
            Found in assets/js/ajaxupload.3.9.js and 1 other location - About 55 mins to fix
            assets/js/ajaxupload.3.9.js on lines 86..86

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status