mambax7/publisher

View on GitHub
blocks/items_columns.php

Summary

Maintainability
C
1 day
Test Coverage

publisher_items_columns_show accesses the super-global variable $GLOBALS.
Open

function publisher_items_columns_show($options)
{
    //    global $xoTheme;
    $helper = Helper::getInstance();
    /** @var CategoryHandler $categoryHandler */
Severity: Minor
Found in blocks/items_columns.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function publisher_items_columns_show has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

function publisher_items_columns_show($options)
{
    //    global $xoTheme;
    $helper = Helper::getInstance();
    /** @var CategoryHandler $categoryHandler */
Severity: Minor
Found in blocks/items_columns.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method publisher_items_columns_show has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function publisher_items_columns_show($options)
{
    //    global $xoTheme;
    $helper = Helper::getInstance();
    /** @var CategoryHandler $categoryHandler */
Severity: Major
Found in blocks/items_columns.php - About 3 hrs to fix

    Method publisher_items_columns_edit has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function publisher_items_columns_edit($options)
    {
        // require_once PUBLISHER_ROOT_PATH . '/class/blockform.php';
        xoops_load('XoopsFormLoader');
    
    
    Severity: Minor
    Found in blocks/items_columns.php - About 1 hr to fix

      The function publisher_items_columns_show() has 117 lines of code. Current threshold is set to 100. Avoid really long methods.
      Open

      function publisher_items_columns_show($options)
      {
          //    global $xoTheme;
          $helper = Helper::getInstance();
          /** @var CategoryHandler $categoryHandler */
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      The function publisher_items_columns_show() has an NPath complexity of 9600. The configured NPath complexity threshold is 200.
      Open

      function publisher_items_columns_show($options)
      {
          //    global $xoTheme;
          $helper = Helper::getInstance();
          /** @var CategoryHandler $categoryHandler */
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The function publisher_items_columns_show() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
      Open

      function publisher_items_columns_show($options)
      {
          //    global $xoTheme;
          $helper = Helper::getInstance();
          /** @var CategoryHandler $categoryHandler */
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '179', column '19').
      Open

          $catEle = new \XoopsFormLabel(_MB_PUBLISHER_SELECTCAT, Utility::createCategorySelect($options[1], 0, true, 'options[1]'));
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '169', column '19').
      Open

          $colEle = new \XoopsFormSelect(_MB_PUBLISHER_NUMBER_COLUMN_VIEW, 'options[0]', $options[0]);
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '183', column '24').
      Open

          $truncateEle = new \XoopsFormText(_MB_PUBLISHER_TRUNCATE, 'options[3]', 4, 255, $options[3]);
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '193', column '21').
      Open

          $dateSub  = new \XoopsFormRadioYN(_MB_PUBLISHER_DISPLAY_DATE_SUBITEM, 'options[6]', $options[6]);
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '181', column '22').
      Open

          $cItemsEle = new \XoopsFormText(_MB_PUBLISHER_NUMBER_ITEMS_CAT, 'options[2]', 4, 255, $options[2]);
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '185', column '20').
      Open

          $tempEle = new \XoopsFormSelect(_MB_PUBLISHER_TEMPLATE, 'options[4]', $options[4]);
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '192', column '21').
      Open

          $dateMain = new \XoopsFormRadioYN(_MB_PUBLISHER_DISPLAY_DATE_MAINITEM, 'options[5]', $options[5]);
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method publisher_items_columns_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

          } else {
              foreach ($categoriesObj as $key => $value) {
                  if (in_array($key, $selCategories, true)) {
                      $selCategoriesObj[$key] = $value;
                  }
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'publisher_items_columns_edit'.
      Open

          $catEle = new \XoopsFormLabel(_MB_PUBLISHER_SELECTCAT, Utility::createCategorySelect($options[1], 0, true, 'options[1]'));
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Publisher\Helper' in method 'publisher_items_columns_show'.
      Open

          $helper = Helper::getInstance();
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid unused local variables such as '$itemId'.
      Open

                      foreach ($categoryItemsObj as $itemId => $thisItem) {
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      TODO found
      Open

                          //TODO do I need to start with 2nd element?
      Severity: Minor
      Found in blocks/items_columns.php by fixme

      Avoid variables with short names like $k. Configured minimum length is 3.
      Open

          $k       = 0;
      Severity: Minor
      Found in blocks/items_columns.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 38 and the first side effect is on line 29.
      Open

      <?php
      Severity: Minor
      Found in blocks/items_columns.php by phpcodesniffer

      There must be one USE keyword per declaration
      Open

      use XoopsModules\Publisher\{BlockForm,
      Severity: Minor
      Found in blocks/items_columns.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status