mambax7/publisher

View on GitHub
blocks/latest_news.php

Summary

Maintainability
F
3 days
Test Coverage

publisher_latest_news_show accesses the super-global variable $GLOBALS.
Open

function publisher_latest_news_show($options)
{
    $block = [];

    $configurator = new Configurator();
Severity: Minor
Found in blocks/latest_news.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

publisher_latest_news_show accesses the super-global variable $GLOBALS.
Open

function publisher_latest_news_show($options)
{
    $block = [];

    $configurator = new Configurator();
Severity: Minor
Found in blocks/latest_news.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

publisher_latest_news_show accesses the super-global variable $GLOBALS.
Open

function publisher_latest_news_show($options)
{
    $block = [];

    $configurator = new Configurator();
Severity: Minor
Found in blocks/latest_news.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

publisher_latest_news_show accesses the super-global variable $GLOBALS.
Open

function publisher_latest_news_show($options)
{
    $block = [];

    $configurator = new Configurator();
Severity: Minor
Found in blocks/latest_news.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

publisher_latest_news_show accesses the super-global variable $GLOBALS.
Open

function publisher_latest_news_show($options)
{
    $block = [];

    $configurator = new Configurator();
Severity: Minor
Found in blocks/latest_news.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

publisher_latest_news_show accesses the super-global variable $GLOBALS.
Open

function publisher_latest_news_show($options)
{
    $block = [];

    $configurator = new Configurator();
Severity: Minor
Found in blocks/latest_news.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function publisher_latest_news_show has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
Open

function publisher_latest_news_show($options)
{
    $block = [];

    $configurator = new Configurator();
Severity: Minor
Found in blocks/latest_news.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method publisher_latest_news_show has 195 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function publisher_latest_news_show($options)
{
    $block = [];

    $configurator = new Configurator();
Severity: Major
Found in blocks/latest_news.php - About 7 hrs to fix

    Method publisher_latest_news_edit has 133 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function publisher_latest_news_edit($options)
    {
        $tabletag1 = '<tr><td style="padding:3px;" width="37%">';
        $tabletag2 = '</td><td style="padding:3px;">';
        $tabletag3 = '<tr><td style="padding-top:20px;border-bottom:1px solid #000;" colspan="2">';
    Severity: Major
    Found in blocks/latest_news.php - About 5 hrs to fix

      File latest_news.php has 378 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      declare(strict_types=1);
      /*
       You may not change or alter any portion of this comment or credits
      Severity: Minor
      Found in blocks/latest_news.php - About 5 hrs to fix

        Function publisher_latest_news_edit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        function publisher_latest_news_edit($options)
        {
            $tabletag1 = '<tr><td style="padding:3px;" width="37%">';
            $tabletag2 = '</td><td style="padding:3px;">';
            $tabletag3 = '<tr><td style="padding-top:20px;border-bottom:1px solid #000;" colspan="2">';
        Severity: Minor
        Found in blocks/latest_news.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The function publisher_latest_news_edit() has an NPath complexity of 576. The configured NPath complexity threshold is 200.
        Open

        function publisher_latest_news_edit($options)
        {
            $tabletag1 = '<tr><td style="padding:3px;" width="37%">';
            $tabletag2 = '</td><td style="padding:3px;">';
            $tabletag3 = '<tr><td style="padding-top:20px;border-bottom:1px solid #000;" colspan="2">';
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The function publisher_latest_news_show() has an NPath complexity of 12230590536. The configured NPath complexity threshold is 200.
        Open

        function publisher_latest_news_show($options)
        {
            $block = [];
        
            $configurator = new Configurator();
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The function publisher_latest_news_show() has 249 lines of code. Current threshold is set to 100. Avoid really long methods.
        Open

        function publisher_latest_news_show($options)
        {
            $block = [];
        
            $configurator = new Configurator();
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        The function publisher_latest_news_edit() has 149 lines of code. Current threshold is set to 100. Avoid really long methods.
        Open

        function publisher_latest_news_edit($options)
        {
            $tabletag1 = '<tr><td style="padding:3px;" width="37%">';
            $tabletag2 = '</td><td style="padding:3px;">';
            $tabletag3 = '<tr><td style="padding-top:20px;border-bottom:1px solid #000;" colspan="2">';
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        The function publisher_latest_news_show() has a Cyclomatic Complexity of 40. The configured cyclomatic complexity threshold is 10.
        Open

        function publisher_latest_news_show($options)
        {
            $block = [];
        
            $configurator = new Configurator();
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The function publisher_latest_news_edit() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
        Open

        function publisher_latest_news_edit($options)
        {
            $tabletag1 = '<tr><td style="padding:3px;" width="37%">';
            $tabletag2 = '</td><td style="padding:3px;">';
            $tabletag3 = '<tr><td style="padding-top:20px;border-bottom:1px solid #000;" colspan="2">';
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Missing class import via use statement (line '91', column '29').
        Open

                    $criteria = new \CriteriaCompo();
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '77', column '25').
        Open

                $criteria = new \CriteriaCompo();
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '93', column '32').
        Open

                $criteriaDateSub = new \Criteria('datesub', time(), '<=');
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '84', column '25').
        Open

                $criteria = new \CriteriaCompo();
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '85', column '28').
        Open

                $criteria->add(new \Criteria('itemid', '(' . $selectedStories . ')', 'IN'));
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '78', column '28').
        Open

                $criteria->add(new \Criteria('categoryid', '(' . $options[31] . ')', 'IN'));
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'publisher_latest_news_edit'.
        Open

            $form .= Utility::createCategorySelect($options[31], 0, true, 'options[31]');
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\XoopsModules\Publisher\Helper' in method 'publisher_latest_news_show'.
        Open

            $helper = Helper::getInstance();
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\XoopsModules\Publisher\Seo' in method 'publisher_latest_news_show'.
        Open

                    $item['print'] = '<a href="' . Seo::generateUrl('print', $itemObj->itemid(), $itemObj->short_url()) . '" rel="nofollow">' . $icons['print'] . '</a>&nbsp;';
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'publisher_latest_news_show'.
        Open

            $order           = Utility::getOrderBy($sort);
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
        {
            public function bar()
            {
                Bar::baz();
            }
        }

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method publisher_latest_news_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

            } else {
                $criteria = new \CriteriaCompo();
                $criteria->add(new \Criteria('categoryid', '(' . $options[31] . ')', 'IN'));
            }
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method publisher_latest_news_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
                    $item['item_image'] = PUBLISHER_URL . '/thumb.php?src=' . $mainImage['image_path'] . '&amp;w=' . $imgWidth; // No $imgHeight for autoheight option
                    $item['image_path'] = $mainImage['image_path'];
                }
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method publisher_latest_news_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                    } else {
                        $item['comment'] = '&nbsp;' . _MB_PUBLISHER_NO_COMMENTS . '&nbsp;';
                    }
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method publisher_latest_news_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
                    $item['admin'] = '';
                }
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method publisher_latest_news_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                        } else {
                            $item['comment'] = '&nbsp;' . $comments . '&nbsp;' . _MB_PUBLISHER_COMMENTS . '&nbsp;';
                        }
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
        {
            public function bar($flag)
            {
                if ($flag) {
                    // one branch
                } else {
                    // another branch
                }
            }
        }

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid unused local variables such as '$itemId'.
        Open

            foreach ($itemsObj as $itemId => $itemObj) {
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        UnusedLocalVariable

        Since: 0.2

        Detects when a local variable is declared and/or assigned, but not used.

        Example

        class Foo {
            public function doSomething()
            {
                $i = 5; // Unused
            }
        }

        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

        TODO found
        Open

                //TODO: Should we not show link to Anonymous?
        Severity: Minor
        Found in blocks/latest_news.php by fixme

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                    if ($comments > 0) {
                        //shows 1 comment instead of 1 comm. if comments ==1
                        //langugage file modified accordingly
                        if (1 == $comments) {
                            $item['comment'] = '&nbsp;' . _MB_PUBLISHER_ONECOMMENT . '&nbsp;';
        Severity: Major
        Found in blocks/latest_news.php and 5 other locations - About 55 mins to fix
        blocks/items_new.php on lines 100..110
        blocks/items_random_item.php on lines 79..89
        blocks/items_recent.php on lines 105..115
        archive.php on lines 235..245
        item.php on lines 166..176

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid variables with short names like $k. Configured minimum length is 3.
        Open

            $k       = 0;
        Severity: Minor
        Found in blocks/latest_news.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
            private $q = 15; // VIOLATION - Field
            public static function main( array $as ) { // VIOLATION - Formal
                $r = 20 + $this->q; // VIOLATION - Local
                for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                    $r += $this->q;
                }
            }
        }

        Source https://phpmd.org/rules/naming.html#shortvariable

        A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 39 and the first side effect is on line 32.
        Open

        <?php
        Severity: Minor
        Found in blocks/latest_news.php by phpcodesniffer

        There must be one USE keyword per declaration
        Open

        use XoopsModules\Publisher\{
        Severity: Minor
        Found in blocks/latest_news.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status