mambax7/publisher

View on GitHub
blocks/search.php

Summary

Maintainability
C
1 day
Test Coverage

Method publisher_search_show has 119 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function publisher_search_show($options)
{
    $block  = [];
    $helper = Helper::getInstance();
    /** @var CategoryHandler $categoryHandler */
Severity: Major
Found in blocks/search.php - About 4 hrs to fix

    Function publisher_search_show has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

    function publisher_search_show($options)
    {
        $block  = [];
        $helper = Helper::getInstance();
        /** @var CategoryHandler $categoryHandler */
    Severity: Minor
    Found in blocks/search.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The function publisher_search_show() has 143 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

    function publisher_search_show($options)
    {
        $block  = [];
        $helper = Helper::getInstance();
        /** @var CategoryHandler $categoryHandler */
    Severity: Minor
    Found in blocks/search.php by phpmd

    The function publisher_search_show() has an NPath complexity of 403107840. The configured NPath complexity threshold is 200.
    Open

    function publisher_search_show($options)
    {
        $block  = [];
        $helper = Helper::getInstance();
        /** @var CategoryHandler $categoryHandler */
    Severity: Minor
    Found in blocks/search.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The function publisher_search_show() has a Cyclomatic Complexity of 36. The configured cyclomatic complexity threshold is 10.
    Open

    function publisher_search_show($options)
    {
        $block  = [];
        $helper = Helper::getInstance();
        /** @var CategoryHandler $categoryHandler */
    Severity: Minor
    Found in blocks/search.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $sortby = Request::getString('sortby', Request::getString('sortby', null, 'GET'), 'POST');
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $category = Request::getArray('category', [], 'POST') ?: Request::getArray('category', null, 'GET');
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $sortby = Request::getString('sortby', Request::getString('sortby', null, 'GET'), 'POST');
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $andor    = Request::getString('andor', Request::getString('andor', '', 'GET'), 'POST');
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $term   = Request::getString('term', Request::getString('term', '', 'GET'));
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $category = Request::getArray('category', [], 'POST') ?: Request::getArray('category', null, 'GET');
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $username = Request::getString('uname', Request::getString('uname', null, 'GET'), 'POST');
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method publisher_search_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

        } else {
            $category = (!is_array($category)) ? explode(',', $category) : $category;
            $category = array_map('\intval', $category);
        }
    Severity: Minor
    Found in blocks/search.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $searchin = Request::getArray('searchin', '', 'POST');
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $username = Request::getString('uname', Request::getString('uname', null, 'GET'), 'POST');
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\XoopsModules\Publisher\Helper' in method 'publisher_search_show'.
    Open

        $helper = Helper::getInstance();
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

            $searchin = Request::getString('searchin', [], 'GET');
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $term   = Request::getString('term', Request::getString('term', '', 'GET'));
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Xmf\Request' in method 'publisher_search_show'.
    Open

        $andor    = Request::getString('andor', Request::getString('andor', '', 'GET'), 'POST');
    Severity: Minor
    Found in blocks/search.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused parameters such as '$options'.
    Open

    function publisher_search_show($options)
    Severity: Minor
    Found in blocks/search.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    TODO found
    Open

        //mb TODO simplify next lines with category
    Severity: Minor
    Found in blocks/search.php by fixme

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if (empty($category) || (is_array($category) && in_array('all', $category, true))) {
            $category = [];
        } else {
            $category = (!is_array($category)) ? explode(',', $category) : $category;
            $category = array_map('\intval', $category);
    Severity: Minor
    Found in blocks/search.php and 1 other location - About 55 mins to fix
    search.php on lines 71..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 34 and the first side effect is on line 27.
    Open

    <?php
    Severity: Minor
    Found in blocks/search.php by phpcodesniffer

    There must be one USE keyword per declaration
    Open

    use XoopsModules\Publisher\{CategoryHandler,
    Severity: Minor
    Found in blocks/search.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status