mambax7/publisher

View on GitHub
class/Common/MigrateHelper.php

Summary

Maintainability
D
1 day
Test Coverage

Function createSchemaFromSqlfile has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

    public function createSchemaFromSqlfile(): bool
    {
        if (!\is_file($this->fileSql)) {
            \xoops_error('Error: Sql file not found!');
            return false;
Severity: Minor
Found in class/Common/MigrateHelper.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createSchemaFromSqlfile has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createSchemaFromSqlfile(): bool
    {
        if (!\is_file($this->fileSql)) {
            \xoops_error('Error: Sql file not found!');
            return false;
Severity: Major
Found in class/Common/MigrateHelper.php - About 3 hrs to fix

    Function getKey has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getKey(string $line): array
        {
            $key = [];
    
            if (\strpos($line, 'RIMARY') > 0) {
    Severity: Minor
    Found in class/Common/MigrateHelper.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getKey has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getKey(string $line): array
        {
            $key = [];
    
            if (\strpos($line, 'RIMARY') > 0) {
    Severity: Minor
    Found in class/Common/MigrateHelper.php - About 1 hr to fix

      The method createSchemaFromSqlfile() has 125 lines of code. Current threshold is set to 100. Avoid really long methods.
      Open

          public function createSchemaFromSqlfile(): bool
          {
              if (!\is_file($this->fileSql)) {
                  \xoops_error('Error: Sql file not found!');
                  return false;
      Severity: Minor
      Found in class/Common/MigrateHelper.php by phpmd

      The method createSchemaFromSqlfile() has an NPath complexity of 16740. The configured NPath complexity threshold is 200.
      Open

          public function createSchemaFromSqlfile(): bool
          {
              if (!\is_file($this->fileSql)) {
                  \xoops_error('Error: Sql file not found!');
                  return false;
      Severity: Minor
      Found in class/Common/MigrateHelper.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method createSchemaFromSqlfile() has a Cyclomatic Complexity of 28. The configured cyclomatic complexity threshold is 10.
      Open

          public function createSchemaFromSqlfile(): bool
          {
              if (!\is_file($this->fileSql)) {
                  \xoops_error('Error: Sql file not found!');
                  return false;
      Severity: Minor
      Found in class/Common/MigrateHelper.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method createSchemaFromSqlfile uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                          // get keys and fields
                          switch (\mb_strtoupper(\substr($line, 0, 3))) {
                              case 'KEY':
                              case 'PRI':
      Severity: Minor
      Found in class/Common/MigrateHelper.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method getColumns uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
                  return false;
              }
      Severity: Minor
      Found in class/Common/MigrateHelper.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method getKey uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
                  $unique = 'false';
                  if (\strpos($line, 'NIQUE') > 0) {
                      $unique = 'true';
                  }
      Severity: Minor
      Found in class/Common/MigrateHelper.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method createSchemaFromSqlfile uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                          $schema[] = $level1 . 'columns: ' . "\n";
                          foreach ($line as $kkey => $kvalue) {
                              $schema[] = $level2 . '-' . "\n";
                              foreach ($kvalue as $kkey2 => $kvalue2) {
      Severity: Minor
      Found in class/Common/MigrateHelper.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Blank line found at end of control structure
      Open

      
      

      There are no issues that match your filters.

      Category
      Status