mambax7/publisher

View on GitHub
class/MyTextSanitizerExtension.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method rtsp has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function rtsp(&$patterns, &$replacements): void
    {
        $patterns[] = "/\[rtsp=(['\"]?)([^\"']*),([^\"']*)\\1]([^\"]*)\[\/rtsp\]/sU";
        $rp         = "<object classid=\"clsid:CFCDAA03-8BE4-11cf-B84B-0020AFBBCCFA\" HEIGHT='\\3' ID=Player WIDTH='\\2' VIEWASTEXT>";
        $rp         .= '<param NAME="_ExtentX" VALUE="12726">';
Severity: Minor
Found in class/MyTextSanitizerExtension.php - About 1 hr to fix

    Method mms has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function mms(&$patterns, &$replacements): void
        {
            $patterns[]     = "/\[mms=(['\"]?)([^\"']*),([^\"']*)\\1]([^\"]*)\[\/mms\]/sU";
            $rp             = "<OBJECT id=videowindow1 height='\\3' width='\\2' classid='CLSID:6BF52A52-394A-11D3-B153-00C04F79FAA6'>";
            $rp             .= '<PARAM NAME="URL" VALUE="\\4">';
    Severity: Minor
    Found in class/MyTextSanitizerExtension.php - About 1 hr to fix

      Function displayFlash has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function displayFlash($url, $width = false, $height = false)
          {
              if (!$width || !$height) {
                  if (!$dimension = @\getimagesize($url)) {
                      return "<a href='{$url}' target='_blank'>{$url}</a>";
      Severity: Minor
      Found in class/MyTextSanitizerExtension.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method displayFlash has a boolean flag argument $width, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function displayFlash($url, $width = false, $height = false)
      Severity: Minor
      Found in class/MyTextSanitizerExtension.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
          public function bar($flag = true) {
          }
      }

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method displayFlash has a boolean flag argument $height, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function displayFlash($url, $width = false, $height = false)
      Severity: Minor
      Found in class/MyTextSanitizerExtension.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
          public function bar($flag = true) {
          }
      }

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Remove error control operator '@' on line 74.
      Open

          public function displayFlash($url, $width = false, $height = false)
          {
              if (!$width || !$height) {
                  if (!$dimension = @\getimagesize($url)) {
                      return "<a href='{$url}' target='_blank'>{$url}</a>";
      Severity: Minor
      Found in class/MyTextSanitizerExtension.php by phpmd

      ErrorControlOperator

      Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

      Example

      function foo($filePath) {
          $file = @fopen($filPath); // hides exceptions
          $key = @$array[$notExistingKey]; // assigns null to $key
      }

      Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

      The method displayFlash uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      [$width, $height] = [$dimension[0], $dimension[1]];
                  }
      Severity: Minor
      Found in class/MyTextSanitizerExtension.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid assigning values to variables in if clauses and the like (line '74', column '18').
      Open

          public function displayFlash($url, $width = false, $height = false)
          {
              if (!$width || !$height) {
                  if (!$dimension = @\getimagesize($url)) {
                      return "<a href='{$url}' target='_blank'>{$url}</a>";
      Severity: Minor
      Found in class/MyTextSanitizerExtension.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($foo = 'bar') { // possible typo
                  // ...
              }
              if ($baz = 0) { // always false
                  // ...
              }
          }
      }

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Avoid variables with short names like $rp. Configured minimum length is 3.
      Open

              $rp = "<object width='{$width}' height='{$height}' classid='clsid:D27CDB6E-AE6D-11cf-96B8-444553540000' codebase='https://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=5,0,0,0'>";
      Severity: Minor
      Found in class/MyTextSanitizerExtension.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $rp. Configured minimum length is 3.
      Open

              $rp             = "<object classid=\"clsid:6BF52A52-394A-11D3-B153-00C04F79FAA6\" id=\"WindowsMediaPlayer\" width=\"\\2\" height=\"\\3\">\n";
      Severity: Minor
      Found in class/MyTextSanitizerExtension.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $rp. Configured minimum length is 3.
      Open

              $rp         = "<object classid=\"clsid:CFCDAA03-8BE4-11cf-B84B-0020AFBBCCFA\" HEIGHT='\\3' ID=Player WIDTH='\\2' VIEWASTEXT>";
      Severity: Minor
      Found in class/MyTextSanitizerExtension.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $rp. Configured minimum length is 3.
      Open

              $rp             = "<OBJECT id=videowindow1 height='\\3' width='\\2' classid='CLSID:6BF52A52-394A-11D3-B153-00C04F79FAA6'>";
      Severity: Minor
      Found in class/MyTextSanitizerExtension.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 22 and the first side effect is on line 22.
      Open

      <?php declare(strict_types=1);

      There are no issues that match your filters.

      Category
      Status