mambax7/publisher

View on GitHub
class/RatingsHandler.php

Summary

Maintainability
D
1 day
Test Coverage

getItemRating accesses the super-global variable $GLOBALS.
Open

    public function getItemRating($itemId = 0, $source = 0)
    {
        $helper = \XoopsModules\Publisher\Helper::getInstance();

        $itemRating               = [];
Severity: Minor
Found in class/RatingsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getItemRating accesses the super-global variable $GLOBALS.
Open

    public function getItemRating($itemId = 0, $source = 0)
    {
        $helper = \XoopsModules\Publisher\Helper::getInstance();

        $itemRating               = [];
Severity: Minor
Found in class/RatingsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function getItemRating has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

    public function getItemRating($itemId = 0, $source = 0)
    {
        $helper = \XoopsModules\Publisher\Helper::getInstance();

        $itemRating               = [];
Severity: Minor
Found in class/RatingsHandler.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getItemRating has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getItemRating($itemId = 0, $source = 0)
    {
        $helper = \XoopsModules\Publisher\Helper::getInstance();

        $itemRating               = [];
Severity: Major
Found in class/RatingsHandler.php - About 4 hrs to fix

    The method getItemRating() has an NPath complexity of 246. The configured NPath complexity threshold is 200.
    Open

        public function getItemRating($itemId = 0, $source = 0)
        {
            $helper = \XoopsModules\Publisher\Helper::getInstance();
    
            $itemRating               = [];
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method getItemRating() has 144 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        public function getItemRating($itemId = 0, $source = 0)
        {
            $helper = \XoopsModules\Publisher\Helper::getInstance();
    
            $itemRating               = [];
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    The method getItemRating() has a Cyclomatic Complexity of 35. The configured cyclomatic complexity threshold is 10.
    Open

        public function getItemRating($itemId = 0, $source = 0)
        {
            $helper = \XoopsModules\Publisher\Helper::getInstance();
    
            $itemRating               = [];
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The method create has a boolean flag argument $isNew, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function create($isNew = true)
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
        public function bar($flag = true) {
        }
    }

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Missing class import via use statement (line '163', column '29').
    Open

                $criteria = new \CriteriaCompo();
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '242', column '28').
    Open

            $criteria->add(new \Criteria('rate_source', $source));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '110', column '32').
    Open

                $criteria->add(new \Criteria('rate_itemid', $itemId));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '148', column '32').
    Open

                $criteria->add(new \Criteria('rate_value', 0, '<'));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '165', column '32').
    Open

                $criteria->add(new \Criteria('rate_source', $source));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '206', column '32').
    Open

                $criteria->add(new \Criteria('rate_source', $source));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '207', column '32').
    Open

                $criteria->add(new \Criteria('rate_value', 0, '>'));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '109', column '29').
    Open

                $criteria = new \CriteriaCompo();
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '205', column '32').
    Open

                $criteria->add(new \Criteria('rate_itemid', $itemId));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '166', column '32').
    Open

                $criteria->add(new \Criteria('rate_value', 0, '>'));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '186', column '32').
    Open

                $criteria->add(new \Criteria('rate_itemid', $itemId));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '111', column '32').
    Open

                $criteria->add(new \Criteria('rate_source', $source));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '146', column '32').
    Open

                $criteria->add(new \Criteria('rate_itemid', $itemId));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '240', column '25').
    Open

            $criteria = new \CriteriaCompo();
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '145', column '29').
    Open

                $criteria = new \CriteriaCompo();
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '147', column '32').
    Open

                $criteria->add(new \Criteria('rate_source', $source));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '188', column '32').
    Open

                $criteria->add(new \Criteria('rate_value', 0, '<'));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '164', column '32').
    Open

                $criteria->add(new \Criteria('rate_itemid', $itemId));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '185', column '29').
    Open

                $criteria = new \CriteriaCompo();
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '187', column '32').
    Open

                $criteria->add(new \Criteria('rate_source', $source));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '241', column '28').
    Open

            $criteria->add(new \Criteria('rate_itemid', $itemId));
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '204', column '29').
    Open

                $criteria = new \CriteriaCompo();
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method getItemRating uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                    $text      = \str_replace('%c', $itemRating['avg_rate_value'], \_MA_PUBLISHER_RATING_CURRENT_X);
                    $shorttext = \str_replace('%c', $itemRating['avg_rate_value'], \_MA_PUBLISHER_RATING_CURRENT_SHORT_X);
                }
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\XoopsModules\Publisher\Helper' in method 'getItemRating'.
    Open

            $helper = \XoopsModules\Publisher\Helper::getInstance();
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method getItemRating uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
                $itemRating['uid']        = $uid;
                $itemRating['nb_ratings'] = $count;
                $itemRating['voted']      = $voted;
                $itemRating['ip']         = $ip;
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method getItemRating uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                    $max_units = 10;
                }
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                if (1 == $count) {
                    $text      = \str_replace('%c', $itemRating['avg_rate_value'], \_MA_PUBLISHER_RATING_CURRENT_1);
                    $shorttext = \str_replace('%c', $itemRating['avg_rate_value'], \_MA_PUBLISHER_RATING_CURRENT_SHORT_1);
                } else {
                    $text      = \str_replace('%c', $itemRating['avg_rate_value'], \_MA_PUBLISHER_RATING_CURRENT_X);
    Severity: Major
    Found in class/RatingsHandler.php and 2 other locations - About 1 hr to fix
    class/VoteHandler.php on lines 119..125
    class/VoteHandler.php on lines 284..290

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid variables with short names like $i. Configured minimum length is 3.
    Open

        public function get($i = null, $fields = null)
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $ip. Configured minimum length is 3.
    Open

            $ip                       = \getenv('REMOTE_ADDR');
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

        public function __construct(\XoopsDatabase $db)
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 30 and the first side effect is on line 25.
    Open

    <?php
    Severity: Minor
    Found in class/RatingsHandler.php by phpcodesniffer

    Blank line found at end of control structure
    Open

    
    
    Severity: Minor
    Found in class/RatingsHandler.php by phpcodesniffer

    The variable $max_units is not named in camelCase.
    Open

        public function getItemRating($itemId = 0, $source = 0)
        {
            $helper = \XoopsModules\Publisher\Helper::getInstance();
    
            $itemRating               = [];
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $max_units is not named in camelCase.
    Open

        public function getItemRating($itemId = 0, $source = 0)
        {
            $helper = \XoopsModules\Publisher\Helper::getInstance();
    
            $itemRating               = [];
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $rating_unitwidth is not named in camelCase.
    Open

        public function getItemRating($itemId = 0, $source = 0)
        {
            $helper = \XoopsModules\Publisher\Helper::getInstance();
    
            $itemRating               = [];
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $rating_unitwidth is not named in camelCase.
    Open

        public function getItemRating($itemId = 0, $source = 0)
        {
            $helper = \XoopsModules\Publisher\Helper::getInstance();
    
            $itemRating               = [];
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $max_units is not named in camelCase.
    Open

        public function getItemRating($itemId = 0, $source = 0)
        {
            $helper = \XoopsModules\Publisher\Helper::getInstance();
    
            $itemRating               = [];
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $max_units is not named in camelCase.
    Open

        public function getItemRating($itemId = 0, $source = 0)
        {
            $helper = \XoopsModules\Publisher\Helper::getInstance();
    
            $itemRating               = [];
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $rating_unitwidth is not named in camelCase.
    Open

        public function getItemRating($itemId = 0, $source = 0)
        {
            $helper = \XoopsModules\Publisher\Helper::getInstance();
    
            $itemRating               = [];
    Severity: Minor
    Found in class/RatingsHandler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status